After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747106 - If the profile specified on the commandline is not found, use the default one
If the profile specified on the commandline is not found, use the default one
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-31 11:57 UTC by Iain Lane
Modified: 2015-04-01 18:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
If the profile specified on the commandline is not found, use the default one (1.95 KB, patch)
2015-03-31 11:57 UTC, Iain Lane
none Details | Review
If the profile specified on the commandline is not found, use the default one (1.85 KB, patch)
2015-03-31 18:19 UTC, Iain Lane
none Details | Review
If the profile specified on the commandline is not found, use the default one (1.96 KB, patch)
2015-04-01 11:02 UTC, Iain Lane
none Details | Review

Description Iain Lane 2015-03-31 11:57:00 UTC
In previous releases (3.8?) this was the behaviour.
Comment 1 Iain Lane 2015-03-31 11:57:04 UTC
Created attachment 300661 [details] [review]
If the profile specified on the commandline is not found, use the default one

Users may have .desktop files or scripts referring to profiles they've
deleted.
Comment 2 Christian Persch 2015-03-31 12:50:58 UTC
Comment on attachment 300661 [details] [review]
If the profile specified on the commandline is not found, use the default one

Should use g_printerr() instead of g_warning(), and  terminal_settings_list_dup_default_child() instead of terminal_profiles_list_dup_uuid_or_name(NULL)
Comment 3 Iain Lane 2015-03-31 18:19:20 UTC
Created attachment 300696 [details] [review]
If the profile specified on the commandline is not found, use the default one

Users may have .desktop files or scripts referring to profiles they've
deleted.
Comment 4 Christian Persch 2015-03-31 18:27:09 UTC
Comment on attachment 300696 [details] [review]
If the profile specified on the commandline is not found, use the default one

Hmm. I overlooked the issue of @error, so it's probably best (although failure is very very unlikely) to go back to terminal_profiles_list_dup_uuid_or_name(NULL). Sorry!

With that changed back, please commit to master and gnome-3-16. Thanks!
Comment 5 Iain Lane 2015-04-01 11:02:02 UTC
Created attachment 300732 [details] [review]
If the profile specified on the commandline is not found, use the default one

Users may have .desktop files or scripts referring to profiles they've
deleted.
Comment 6 Iain Lane 2015-04-01 11:02:21 UTC
No worries. I can't commit myself though - please could you do that for me?
Comment 7 Christian Persch 2015-04-01 18:56:04 UTC
Pushed to master and 3-16.