GNOME Bugzilla – Bug 747058
Create button should be the right-most in the create event popover
Last modified: 2017-04-17 18:20:40 UTC
In the event popover there are two buttons in the bottom, "Cancel" and "Create". Currently the Create button is on the left (in an LTR locale). This button should probably be the default action and thus on the right according to the HIG.
Actually, the left-most button is ofcourse titled "Edit Details" not "Cancel". But still "Create" would be considered the "default action", shouldn't it?
(In reply to Marcus Lundblad from comment #0) > In the event popover there are two buttons in the bottom, "Cancel" and > "Create". > Currently the Create button is on the left (in an LTR locale). > This button should probably be the default action and thus on the right > according to the HIG. On which part of the HIG did you read that the default button should be on the left. Here [1], all I read it's that you need to place Cancel, or safe action first, before the default action. But, here the two actions are affirmative, sort of. So, in those docs, the order of these kinds of dialog isn't specified. [1]: https://developer.gnome.org/hig/stable/dialogs.html.en
Cancel isn't a positive action. Create should be the default, and thus, rightmost, indeed.
(In reply to Bastien Nocera from comment #3) > Cancel isn't a positive action. Create should be the default, and thus, > rightmost, indeed. There's no Cancel in there, just "Create" and "More details"
Created attachment 317110 [details] [review] Create event popover: swap buttons' position. In the create event popover, the Create button is considered to be the right-most button. Because create is a positive action, it seems that it should be the default at the rightmost position. Swaped create_button and details_button's left_attach arguments.
Attachment 317110 [details] pushed as dc1a7f5 - Create event popover: swap buttons' position. A clean, straightforward patch. Thanks for your contribution! Looking forward more patches :) Marking this bug as FIXED