After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747054 - Changing the subsampling on overwriting a JPG does not deselect "Use quality settings from original image"
Changing the subsampling on overwriting a JPG does not deselect "Use quality ...
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: Plugins
git master
Other All
: Normal minor
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2015-03-30 18:33 UTC by sworddragon2
Modified: 2018-05-24 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description sworddragon2 2015-03-30 18:33:42 UTC
Changing the subsampling on overwriting a JPG if the option "Use quality settings from original image" is selected does not deselect this option while selecting it (after a manual deselect) does set the subsampling to the original value of the image.
Comment 1 Joao S. O. Bueno 2015-03-30 19:47:52 UTC
I am not sure if it should do so. The checkbox is about the "quality" check. -
the plug-in does not preserve the subsampling setting, if everything else is unchanged - the default of 4:4:4 is always used, even if the image was read form a JPG file with a different subsampling.

On the other hand, the tooltip hint for that control seems to imply that subsampling should indeed be preserved. Are there any other options that should be inclded in this?
Comment 2 sworddragon2 2015-03-30 20:43:46 UTC
If I'm selecting "Use quality settings from original image" the subsampling is always changed back to its original value (which is not always 4:4:4).
Comment 3 sworddragon2 2015-03-30 20:48:47 UTC
Edit: I can't change the status from NEEDINFO to UNCONFIRMED (an error message says that I'm not allowed to set the "Ever confirmed" field from 1 to 0) and setting the status to RESOLVED would be currently not correct.
Comment 4 Joao S. O. Bueno 2015-03-31 20:21:07 UTC
Ok - I could notice the misbehavior this time around - and there are indeed inconsistencies. I saw another problem beyond your report that is

- On re-exporting an JPEG (export as), the "subsambling" setting does not reflect the subsampling that the original image had, even though the "use quality settings from the original image" box is checked. The "Quality" itself does properly reflect that quality setting.

- On toggling off the "use quality settings..." and turning it back on again, the subsampling value does change to  the one in the original image. 

This is a bug: the subsampling setting should be the same by default (or "use same settings" be off by default)

Now the specific issue you describe is that besides that: 

- Manually changing the "quality setting" automatically checks off the "use same setting..." toggle; but changing the "Subsample"  does not do so. 

- but when toggling "use same setting" back on, the "subsample" value is restored to the previous one

The fix should be: 

Keep the "Subsample" setting always consistent with the "use quality settings from the original image" checkbox.
Comment 5 sworddragon2 2015-03-31 21:34:45 UTC
(In reply to Joao S. O. Bueno from comment #4)
> - On toggling off the "use quality settings..." and turning it back on
> again, the subsampling value does change to  the one in the original image. 
> 
> This is a bug: the subsampling setting should be the same by default (or
> "use same settings" be off by default)

Is this really a bug? Would it not be plausible to set the subsampling to the original value of the JPG that gets overwritten if "Use quality settings from original image" gets selected? Also your found re-exporting bug implies that.

The current state is unidirectional: Changing checkbox could change option; Changing option never changes checkbox.
The state that I thought it should be is bidirectional (as it is currently done with the quality slider): Changing checkbox could change option; Changing option could change checkbox.
The state that you think it should be is unbinding this option (except on the initialization process on re-exporting): Changing checkbox never changes option; Changing option never changes checkbox.

Or have I just misunderstood something?
Comment 6 Ofnuts 2018-01-11 09:54:28 UTC
I was going to report this bug when I found this. IMHO the chroma setting should work exactly like the quality slider. When you check the "Use ... initial..." box, this sets the slider to the initial value, and if you move the slider, this resets the "Use ... initial..." option. 

It appears that setting the "Use ... initial..." option currently also sets the Chroma subsampling to the initial value, so changing the CS value should reset "Use ... initial..." option.
Comment 7 GNOME Infrastructure Team 2018-05-24 15:10:06 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/659.