After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747038 - tsparse/tsdemux: incorrect timestamps on PMT change in mpeg TS stream
tsparse/tsdemux: incorrect timestamps on PMT change in mpeg TS stream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 746480
Blocks:
 
 
Reported: 2015-03-30 16:04 UTC by Vincent Penquerc'h
Modified: 2015-04-09 16:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
keep track of current position (1.65 KB, patch)
2015-03-30 16:04 UTC, Vincent Penquerc'h
none Details | Review
send a new segment when a stream is added (1.47 KB, patch)
2015-03-30 16:05 UTC, Vincent Penquerc'h
none Details | Review
fix timestamps not updating after a PMT change (3.12 KB, patch)
2015-03-30 16:05 UTC, Vincent Penquerc'h
none Details | Review

Description Vincent Penquerc'h 2015-03-30 16:04:05 UTC
+++ This bug was initially created as a clone of Bug #746480 +++

The file from the origin bug has a PMT change in the middle, and causes trouble with tsdemux and tsparse emiting wrong timings for the second part.

Patches incoming.
Comment 1 Vincent Penquerc'h 2015-03-30 16:04:39 UTC
Created attachment 300606 [details] [review]
keep track of current position
Comment 2 Vincent Penquerc'h 2015-03-30 16:05:02 UTC
Created attachment 300607 [details] [review]
send a new segment when a stream is added
Comment 3 Vincent Penquerc'h 2015-03-30 16:05:36 UTC
Created attachment 300608 [details] [review]
fix timestamps not updating after a PMT change
Comment 4 Vincent Penquerc'h 2015-04-03 14:44:58 UTC
Feedback from someone familiar with MPEG-TS would be good before I push this.
Comment 5 Vincent Penquerc'h 2015-04-09 15:32:59 UTC
Kinda pushed by mistake along with a new unrelated patch, I'd forgot to branch before debugging these it seems.

Closing as fixed for now.


commit 68f57d20b93a31740ca4047731682d08269c06ac
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Thu Mar 26 13:46:16 2015 +0000

    tsparse: fix timestamps not updating after a PMT change
    
    The PCRs stay locked onto the same PID as before the change,
    but the relevant PID has no reason to be the same after it.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=745102

commit ade79a9ad24a72d1b02f2e35e7dbeaf3bd59bb6c
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Mar 24 12:56:53 2015 +0000

    tsdemux: send new segment when a stream is added
    
    This will happen when the PMT changes, replacing streams with
    new ones. In that case, we need to accumulate the running time
    from the previous chain in the segment base.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=745102

commit fc2460b33196020d034b72741ce04cddf6e3f1b9
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Mon Mar 9 09:56:38 2015 +0000

    tsdemux: keep track of current position
    
    This allows seeking to correctly set the base on the segment.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=745102