GNOME Bugzilla – Bug 746984
build failure with -Werror=format-security
Last modified: 2015-04-28 03:42:15 UTC
Builds with -Werror=format-security are failing due to a missing string argument in one of the test cases. test-gegl-color.c: In function ‘assert_compare_rgba’: test-gegl-color.c:50:9: error: format not a string literal and no format arguments [-Werror=format-security] g_error(str);
Created attachment 300549 [details] [review] tests: fix missing string format argument This causes a build failure when building with -Werror=format-security
Why not pass all the stuff to g_error() directly, instead of building a string and passing that to g_error(), using an additional format string?
right, that is probably cleaner, I initially though there might be a reason for using g_snprintf, but there really doesnt seem to be. The string generated should be a pretty fixed length
Created attachment 300631 [details] [review] tests: fix missing string format argument This causes a build failure when building with -Werror=format-security
Thanks, pushed to master: commit c5c78182d83ed799ab87a0a55eae94f8a734996c Author: Tim Lunn <tim@feathertop.org> Date: Mon Mar 30 08:19:19 2015 +1100 tests: fix missing string format argument This causes a build failure when building with -Werror=format-security https://bugzilla.gnome.org/show_bug.cgi?id=746984 tests/simple/test-gegl-color.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)