After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746920 - out-of-tree builds result in broken HighContrast/index.theme
out-of-tree builds result in broken HighContrast/index.theme
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: HighContrast
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-28 04:29 UTC by Alexandre Rostovtsev
Modified: 2017-08-15 16:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to use $(srcdir) to allow out-of-tree builds (1.06 KB, patch)
2015-03-28 04:32 UTC, Alexandre Rostovtsev 		committed Details | Review

Description Alexandre Rostovtsev 2015-03-28 04:29:30 UTC 
themes/HighContrast/icons/Makefile hard-codes the assumption that srcdir is "./" when cleaning up THEME_DIRS. The result is a HighContrast/index.theme file full of absolute paths to the build temporary directory when building gnome-themes-standard out of source tree - which obviously doesn't work and causes interesting rendering errors in gtk applications.
Comment 1 Alexandre Rostovtsev 2015-03-28 04:32:18 UTC 
Created attachment 300506 [details] [review]
patch to use $(srcdir) to allow out-of-tree builds
Comment 2 Pacho Ramos 2015-11-15 14:15:42 UTC 
Can this be included finally? Thanks
Comment 3 Gilles Dartiguelongue 2017-08-14 16:03:31 UTC 
We have been using this in Gentoo for years now. I think it is safe to merge it.
Comment 4 Cosimo Cecchi 2017-08-14 18:34:26 UTC 
Review of attachment 300506 [details] [review]:

OK, please push to master.
Comment 5 Gilles Dartiguelongue 2017-08-15 08:26:33 UTC 
Thanks.