After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746867 - Clicking twice on a date in the calendar unselects it
Clicking twice on a date in the calendar unselects it
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: calendar
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 756982 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-03-27 07:50 UTC by Arnaud B.
Modified: 2016-07-08 14:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
calendar: Do not overload :active to mark selected day (2.73 KB, patch)
2016-07-08 00:28 UTC, Florian Müllner
none Details | Review
calendar: Do not overload :active to mark selected day (1.35 KB, patch)
2016-07-08 00:28 UTC, Florian Müllner
committed Details | Review
calendar: Do not overload :active to mark selected day (2.73 KB, patch)
2016-07-08 00:30 UTC, Florian Müllner
committed Details | Review

Description Arnaud B. 2015-03-27 07:50:25 UTC
When you click twice on a date, it is unselected (no more in blue in usual theme; circled a little grey, the same as when hovered).
Comment 1 Inactive account 2016-06-23 19:49:10 UTC
I am still experiencing this with GNOME 3.20, I have filed a downstream bug report for my distro here: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1595684
Comment 2 Arnaud B. 2016-06-26 18:17:27 UTC
*** Bug 756982 has been marked as a duplicate of this bug. ***
Comment 3 Florian Müllner 2016-07-08 00:28:03 UTC
Created attachment 331041 [details] [review]
calendar: Do not overload :active to mark selected day

We currently use the :active pseudo class to mark the selected day
in the calendar. Whenever the selected date changes, the class is
added to the corresponding button and removed from all others.
However when the selected date doesn't change (i.e. when clicking
the already selected date), the buttons are not updated and the
use of the :active class conflicts with StButton's builtin handling
of the class - the class is removed on the button up event and the
button is deselected.
Fix this by simply using a different pseudo class.
Comment 4 Florian Müllner 2016-07-08 00:28:53 UTC
Created attachment 331042 [details] [review]
calendar: Do not overload :active to mark selected day

SASS part of the patch.
Comment 5 Florian Müllner 2016-07-08 00:30:36 UTC
Created attachment 331043 [details] [review]
calendar: Do not overload :active to mark selected day

Ooops, accidentally obsoleted the gnome-shell patch with the SASS one, reattaching ...
Comment 6 Rui Matos 2016-07-08 13:59:35 UTC
Review of attachment 331043 [details] [review]:

ok
Comment 7 Rui Matos 2016-07-08 13:59:42 UTC
Review of attachment 331042 [details] [review]:

++
Comment 8 Florian Müllner 2016-07-08 14:09:57 UTC
Attachment 331042 [details] pushed as d184e5c - calendar: Do not overload :active to mark selected day
Attachment 331043 [details] pushed as d184e5c - calendar: Do not overload :active to mark selected day