After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746778 - About Stylesheet: fix typos and delete duplicated rules
About Stylesheet: fix typos and delete duplicated rules
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-25 21:48 UTC by Miguel Vaello Martínez
Modified: 2015-06-16 19:28 UTC
See Also:
GNOME target: ---
GNOME version: 3.15/3.16

Attachments
about css fixes (3.41 KB, patch)
2015-03-25 21:53 UTC, Miguel Vaello Martínez 		committed Details | Review

Description Miguel Vaello Martínez 2015-03-25 21:48:02 UTC 
The attached patch fix some typos and remove a duplicated rule, "#about-subtitle".

I assume that the second is the good one because the CSS is read sequentially and the last rule is applied instead the previous rule.

The table of "memory:about" has a typo: solid and transparent properties there were concatenated by mistake.

Removed some white spaces and placed some brackets next to the rule instead below.
Comment 1 Miguel Vaello Martínez 2015-03-25 21:53:07 UTC 
Created attachment 300312 [details] [review]
about css fixes
Comment 2 Michael Catanzaro 2015-06-16 14:37:29 UTC 
Review of attachment 300312 [details] [review]:

Thanks. Do you need us to commit this?
Comment 3 Miguel Vaello Martínez 2015-06-16 18:40:42 UTC 
(In reply to Michael Catanzaro from comment #2)
> Review of attachment 300312 [details] [review] [review]:
> 
> Thanks. Do you need us to commit this?

I have not permissions to commit.