After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746776 - local-metadata: Remove unused variable
local-metadata: Remove unused variable
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-25 21:22 UTC by Jeremy Whiting
Modified: 2015-03-27 11:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to remove the old unused code. (1.41 KB, patch)
2015-03-25 21:23 UTC, Jeremy Whiting 		accepted-commit_now Details | Review
Remove unused thumbnail_uri since libmediaart refactoring. (1.46 KB, patch)
2015-03-27 11:32 UTC, Victor Toso 		committed Details | Review

Description Jeremy Whiting 2015-03-25 21:22:26 UTC 
Since local-metadata was ported to newer libmediaart with different api it has left an uninitialized variable thumbnail_uri. Removing it reduces complexity.
Comment 1 Jeremy Whiting 2015-03-25 21:23:52 UTC 
Created attachment 300310 [details] [review]
Patch to remove the old unused code.
Comment 2 Victor Toso 2015-03-26 10:11:39 UTC 
Review of attachment 300310 [details] [review]:

Looks fine!
Comment 3 Victor Toso 2015-03-27 11:29:39 UTC 
The following fixes have been pushed:
Comment 4 Victor Toso 2015-03-27 11:32:29 UTC 
The following fix has been pushed:
b2aa521 Remove unused thumbnail_uri since libmediaart refactoring.
Comment 5 Victor Toso 2015-03-27 11:32:34 UTC 
Created attachment 300432 [details] [review]
Remove unused thumbnail_uri since libmediaart refactoring.