After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746759 - sharing: accessibility improvements
sharing: accessibility improvements
Product: gnome-control-center
Classification: Core
Component: Sharing
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Reported: 2015-03-25 16:37 UTC by Matthias Clasen
Modified: 2015-07-27 17:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

proposed patch for the issues in the OR (3.32 KB, patch)
2015-03-25 19:32 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Matthias Clasen 2015-03-25 16:37:12 UTC
The computer name label should be hooked up with the entry with a label-for labelled-by relation pair, so orca knows to read it when presenting the entry.

The switch in the header bar is just read as 'push button' - it should be an accessible name.

The individual rows get all read correctly, e.g. 'Media Sharing off'. But the remote row gets just read as 'off' - something amiss there.
Comment 1 Joanmarie Diggs (IRC: joanie) 2015-03-25 19:32:23 UTC
Created attachment 300307 [details] [review]
proposed patch for the issues in the OR
Comment 2 Matthias Clasen 2015-03-25 20:00:01 UTC
Review of attachment 300307 [details] [review]:

Looks great to me
Comment 3 Bastien Nocera 2015-07-27 16:19:20 UTC
Review of attachment 300307 [details] [review]:

Looks good indeed.

Note though, the prefix for the commit message is just "sharing: "