After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746727 - Some missing examples for gtk-demo
Some missing examples for gtk-demo
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Gtk2
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2015-03-25 06:55 UTC by Thorsten Otto
Modified: 2015-07-01 20:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
adds assistant, builder and combobox examples to gtk-demo (33.17 KB, patch)
2015-03-25 06:55 UTC, Thorsten Otto
none Details | Review
adds assistant example to gtk-demo (7.93 KB, patch)
2015-05-04 16:53 UTC, Thorsten Otto
committed Details | Review
adds builder example to gtk-demo (15.79 KB, patch)
2015-05-04 16:54 UTC, Thorsten Otto
committed Details | Review
adds combobox example to gtk-demo (10.29 KB, patch)
2015-05-04 16:54 UTC, Thorsten Otto
committed Details | Review

Description Thorsten Otto 2015-03-25 06:55:08 UTC
Created attachment 300253 [details] [review]
adds assistant, builder and combobox examples to gtk-demo

Hi,

Please find attached ports of some examples of the C-version of the gtk-demo that where missing in the perl version.

Greetings
Thorsten
Comment 1 Torsten Schoenfeld 2015-04-10 19:35:37 UTC
Looks pretty good, thanks!  But I seem to be unable to apply the patches with 'git am':

# git am ~/Desktop/gtk-demo.patch 
Patch format detection failed.

Did you generate the file with 'git format-patch'?
Comment 2 Thorsten Otto 2015-04-11 07:31:34 UTC
(In reply to Torsten Schoenfeld from comment #1)
> Looks pretty good, thanks!  But I seem to be unable to apply the patches
> with 'git am':
> 
> # git am ~/Desktop/gtk-demo.patch 
> Patch format detection failed.
> 
> Did you generate the file with 'git format-patch'?

No, that are just the plain patch files, generated with 'git diff'. They all contain just a new file, plus a small patch to main.pl to link them into the main dialog.
Comment 3 Torsten Schoenfeld 2015-04-16 15:29:51 UTC
Can you please regenerate the patchset with "git format-patch" then?
Comment 4 Thorsten Otto 2015-05-04 16:53:11 UTC
Created attachment 302884 [details] [review]
adds assistant example to gtk-demo
Comment 5 Thorsten Otto 2015-05-04 16:54:16 UTC
Created attachment 302885 [details] [review]
adds builder example to gtk-demo
Comment 6 Thorsten Otto 2015-05-04 16:54:54 UTC
Created attachment 302886 [details] [review]
adds combobox example to gtk-demo
Comment 7 Thorsten Otto 2015-05-04 16:57:48 UTC
(In reply to Torsten Schoenfeld from comment #3)
> Can you please regenerate the patchset with "git format-patch" then?

Yes, of course (see above). Sorry that it took a while, somehow the mail from bugzilla made it to the spam folder.
Comment 8 Torsten Schoenfeld 2015-07-01 20:00:23 UTC
Thanks a lot, and sorry for the delay.