After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746607 - Please add support for multiple names in $XDG_CURRENT_DESKTOP
Please add support for multiple names in $XDG_CURRENT_DESKTOP
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Desktop
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-22 15:45 UTC by Dmitry Shachnev
Modified: 2015-03-24 11:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
desktop-canvas-view: Support multiple desktop names in XDG_CURRENT_DESKTOP (1.51 KB, patch)
2015-03-22 15:46 UTC, Dmitry Shachnev 		committed Details | Review

Description Dmitry Shachnev 2015-03-22 15:45:20 UTC 
The Desktop Entry Specification says:

"If $XDG_CURRENT_DESKTOP is set then it contains a colon-separated list of strings. In order, each string is considered."

The current implementation considers only the full string when detecting if unity-control-center should be used, but it should consider each part.

The example is Ubuntu GNOME Flashback session, where $XDG_CURRENT_DESKTOP is "GNOME-Flashback:Unity", and the control center is unity-control-center.
Comment 1 Dmitry Shachnev 2015-03-22 15:46:33 UTC 
Created attachment 300078 [details] [review]
desktop-canvas-view: Support multiple desktop names in  XDG_CURRENT_DESKTOP
Comment 2 Cosimo Cecchi 2015-03-22 16:49:48 UTC 
Review of attachment 300078 [details] [review]:

Looks good to me.
Comment 3 Carlos Soriano 2015-03-24 10:07:06 UTC 
I think we were in hard code freeze... is not a problem?
Comment 4 Dmitry Shachnev 2015-03-24 11:23:54 UTC 
Carlos: Oh, sorry.

Please feel free to revert it temporarily (in Ubuntu we have cherry-picked it anyway).