After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746501 - wayland: Drop frames instead of blocking
wayland: Drop frames instead of blocking
Status: RESOLVED OBSOLETE
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 748634
 
 
Reported: 2015-03-20 04:15 UTC by Olivier Crête
Modified: 2015-10-09 12:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that shouldn't be merged (1.46 KB, patch)
2015-03-20 04:15 UTC, Olivier Crête
none Details | Review

Description Olivier Crête 2015-03-20 04:15:57 UTC
Created attachment 299908 [details] [review]
Patch that shouldn't be merged

The current trick of blocking until the frame is rendered is problematic.

1. The callback can take a very long time if the surface is not visible. The problem is that this thing waits while locking the entire display, so it blocks any other object sharing the same display.

2. If the video framerate is higher than the display framerate, you actually want to be dropping frames. The current code doesn't.

The real solution is the presentation interface/protocol/api , but that's finished yet.

So you need a separate thread that receives the events and marks the frame as painted or not. See how waylandsink in gst-plugins-bad works.

Attached a patch that is part of the solution, our app also connects the same display to the mainloop of the application, so it's not a problem for us.
Comment 1 Víctor Manuel Jáquez Leal 2015-05-18 13:51:15 UTC
Oliver, is this bug still valid?

IMO, the commit 522ec79 fixes this issue. Could you confirm it?
Comment 2 Víctor Manuel Jáquez Leal 2015-05-18 13:51:51 UTC
Olivier, sorry.
Comment 3 sreerenj 2015-06-19 12:51:08 UTC
Ping??
Comment 4 Víctor Manuel Jáquez Leal 2015-10-09 12:05:30 UTC
Closing since it looks to be working. Please, reopen if it is not.