After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746448 - valve: Don't drop non-serialized queries when the valve is dropping
valve: Don't drop non-serialized queries when the valve is dropping
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 1.4.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-19 12:50 UTC by Sebastian Dröge (slomo)
Modified: 2015-04-23 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
valve: Don't drop non-serialized queries when the valve is dropping (1.09 KB, patch)
2015-03-19 12:50 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2015-03-19 12:50:46 UTC
See attached patch
Comment 1 Sebastian Dröge (slomo) 2015-03-19 12:50:50 UTC
Created attachment 299811 [details] [review]
valve: Don't drop non-serialized queries when the valve is dropping

Otherwise we end up dropping e.g. CAPS queries, and then upstream just
negotiates to whatever format it wants to. Once the valve is not-dropping
anymore this can easily result in negotiation failing completely.
Comment 2 Olivier Crête 2015-03-19 16:03:27 UTC
Review of attachment 299811 [details] [review]:

I can't thin of any case where this would cause problems even when modifying the pipeline downstreams from the valve, so merge it I guess.
Comment 3 Sebastian Dröge (slomo) 2015-03-20 08:30:57 UTC
commit 6a6188a82f671032bf1c9ce3dd66310075cf4197
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Thu Mar 19 13:51:38 2015 +0100

    valve: Don't drop non-serialized queries when the valve is dropping
    
    Otherwise we end up dropping e.g. CAPS queries, and then upstream just
    negotiates to whatever format it wants to. Once the valve is not-dropping
    anymore this can easily result in negotiation failing completely.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=746448