GNOME Bugzilla – Bug 746448
valve: Don't drop non-serialized queries when the valve is dropping
Last modified: 2015-04-23 13:03:45 UTC
See attached patch
Created attachment 299811 [details] [review] valve: Don't drop non-serialized queries when the valve is dropping Otherwise we end up dropping e.g. CAPS queries, and then upstream just negotiates to whatever format it wants to. Once the valve is not-dropping anymore this can easily result in negotiation failing completely.
Review of attachment 299811 [details] [review]: I can't thin of any case where this would cause problems even when modifying the pipeline downstreams from the valve, so merge it I guess.
commit 6a6188a82f671032bf1c9ce3dd66310075cf4197 Author: Sebastian Dröge <sebastian@centricular.com> Date: Thu Mar 19 13:51:38 2015 +0100 valve: Don't drop non-serialized queries when the valve is dropping Otherwise we end up dropping e.g. CAPS queries, and then upstream just negotiates to whatever format it wants to. Once the valve is not-dropping anymore this can easily result in negotiation failing completely. https://bugzilla.gnome.org/show_bug.cgi?id=746448