After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746431 - gsttask: function gst_task_join should do the argument verification before accessing GstTaskPrivate
gsttask: function gst_task_join should do the argument verification before ac...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-19 05:47 UTC by Prashant Gotarne
Modified: 2015-08-16 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gsttask: Funtion gst_task_join, Argument verification for GstTask done before accessing GstTaskPrivate (1.01 KB, patch)
2015-03-19 06:03 UTC, Prashant Gotarne 		none Details | Review

Description Prashant Gotarne 2015-03-19 05:47:36 UTC 
gsttask: Function gst_task_join should do the argument verification for GstTask before accessing the GstTaskPrivate.
NULL value for the GstTask argument causes Segmentation Fault.
Comment 1 Prashant Gotarne 2015-03-19 06:03:42 UTC 
Created attachment 299786 [details] [review]
gsttask: Funtion gst_task_join, Argument verification for GstTask done before accessing GstTaskPrivate

gsttask: Funtion gst_task_join, Argument verification for GstTask done before accessing GstTaskPrivate to avoid Segmentation Fault cause because of NULL GstTask argument.
Comment 2 Tim-Philipp Müller 2015-07-13 13:18:56 UTC 
Thanks pushed squashed with the other patch:

commit 3cea60dc6f2d7f8641107348c4a6576308e601cc
Author: Prashant Gotarne <ps.gotarne@samsung.com>
Date:   Wed Mar 18 16:05:34 2015 +0530

    task: add function guard for _set_lock() and fix guard for _join()
    
    Should only access the object structure after checking
    it's valid in gst_task_join().
    
    https://bugzilla.gnome.org/show_bug.cgi?id=746385
    https://bugzilla.gnome.org/show_bug.cgi?id=746431