After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746430 - tests: clock: Wrong testclock's name for test clock example.
tests: clock: Wrong testclock's name for test clock example.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other Linux
: Normal minor
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-19 04:27 UTC by Suhwang Kim
Modified: 2015-04-15 08:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
this patch is for the wrong testclock's name for example clock code. (1011 bytes, patch)
2015-03-19 04:45 UTC, Suhwang Kim 		none Details | Review
I reformat the title of the commit as your comment. (1.09 KB, patch)
2015-04-15 00:37 UTC, Suhwang Kim 		none Details | Review

Description Suhwang Kim 2015-03-19 04:27:33 UTC 
In the testcode about clock, there is a wrong clock name.
So I fixed it.
Comment 1 Suhwang Kim 2015-03-19 04:45:43 UTC 
Created attachment 299783 [details] [review]
this patch is for the wrong testclock's name for example clock code.
Comment 2 Thiago Sousa Santos 2015-04-09 20:25:19 UTC 
Review of attachment 299783 [details] [review]:

Thanks for the patch. Could you provide a new version that has your name properly written in the author field?

Also please reformat the title of the commit to follow the pattern used in gstreamer. Something like:

tests: clock: <short summary>

<description>

<bug url>


Thanks!
Comment 3 Suhwang Kim 2015-04-15 00:37:18 UTC 
Created attachment 301584 [details] [review]
I reformat the title of the commit as your comment.

I reformat the title of the commit message as your comment.
Comment 4 Tim-Philipp Müller 2015-04-15 08:37:51 UTC 
Thanks, pushed:

commit be6d3e9255099c09d00e1676f6326b79972deaa6
Author: Suhwang Kim <suhwang.kim@lge.com>
Date:   Tue Apr 14 13:42:55 2015 +0900

    tests: clock: fix test clock name
    
    Don't call the slave test clock "Master".
    
    https://bugzilla.gnome.org/show_bug.cgi?id=746430