After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746424 - Add additional fields to gexiv2_metadata_get_comment function
Add additional fields to gexiv2_metadata_get_comment function
Status: RESOLVED FIXED
Product: gexiv2
Classification: Other
Component: general
unspecified
Other Linux
: Normal enhancement
: 0.10.4
Assigned To: Gexiv2 Maintainers
Gexiv2 Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-18 23:48 UTC by Alan Pater
Modified: 2015-03-26 20:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
adds-Xmp.dc.subject-and-Xmp.acdsee.notes (3.54 KB, patch)
2015-03-18 23:50 UTC, Alan Pater 		none Details | Review
TYPO: Xmp.dc.description NOT Xmp.dc.subject (1.98 KB, patch)
2015-03-19 00:06 UTC, Alan Pater 		none Details | Review
dublin core description patch (3.99 KB, patch)
2015-03-19 02:59 UTC, Alan Pater 		none Details | Review
Python test script to read and write description fields. (252 bytes, text/x-python)
2015-03-19 19:20 UTC, Alan Pater 		  Details
Fresh patch: MWG addition to get_comment (3.49 KB, patch)
2015-03-20 05:20 UTC, Alan Pater 		none Details | Review

Description Alan Pater 2015-03-18 23:48:03 UTC 
Add Xmp.dc.subject and Xmp.acdsee.notes fields to gexiv2_metadata_get_comment.

Xmp.dc.subject is part of MWG guidelines. Including Xmp.acdsee.notes will help ACDSee users to migrate away from that proprietory Windows application.

According to Metadata Working Group guidelines section 5.2, Description, Exif ImageDescription, IPTC Caption, and XMP (dc:description) are mapped together. gexiv2 already includes the first two of those.
Comment 1 Alan Pater 2015-03-18 23:50:51 UTC 
Created attachment 299771 [details] [review]
adds-Xmp.dc.subject-and-Xmp.acdsee.notes
Comment 2 Alan Pater 2015-03-18 23:53:40 UTC 
A question about the gexiv2_metadata_get_comment function. MWG refers to these fields as "description" rather then "comment".

Is there a way to setup an alias, such as the function could also be referred to as: gexiv2_metadata_get_description?
Comment 3 Alan Pater 2015-03-19 00:06:37 UTC 
Created attachment 299772 [details] [review]
TYPO: Xmp.dc.description NOT Xmp.dc.subject

Sorry, 1st patch added Xmp.dc.subject. It should have been Xmp.dc.description.
Comment 4 Alan Pater 2015-03-19 02:59:27 UTC 
Created attachment 299778 [details] [review]
dublin core description patch

Original patch had missing line and a typo.
Comment 5 Alan Pater 2015-03-19 19:20:16 UTC 
Created attachment 299869 [details]
Python test script to read and write description fields.

This script confirms that the patch works. A test file with only the Xmp.acdsee.categories tag set was used. The script read in the contents of that tag and wrote that content to the other description tags.

Exif.Image.ImageDescription    Ascii      92  Quebec  - Chateau Frontenac
Exif.Photo.UserComment         Undefined  99  Quebec  - Chateau Frontenac
Iptc.Application2.Caption      String     91  Quebec  - Chateau Frontenac
Xmp.acdsee.notes               XmpText    91  Quebec  - Chateau Frontenac
Xmp.dc.description             LangAlt     1  lang="x-default" Quebec  - Chateau Frontenac
Comment 6 Jim Nelson 2015-03-20 03:22:38 UTC 
Review of attachment 299778 [details] [review]:

Alan, git and patch both report that this patch is malformed at line 49.  Could you re-upload?
Comment 7 Alan Pater 2015-03-20 05:20:33 UTC 
Created attachment 299912 [details] [review]
Fresh patch: MWG addition to get_comment
Comment 8 Jim Nelson 2015-03-26 20:19:21 UTC 
Thanks!

Pushed to master, commit bdc9be3