After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746366 - The collection's title is not being shown in the toolbar
The collection's title is not being shown in the toolbar
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.15.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-03-17 20:22 UTC by Debarshi Ray
Modified: 2015-03-18 10:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
embed: Fix typo (793 bytes, patch)
2015-03-17 20:27 UTC, Debarshi Ray 		committed Details | Review
mainToolbar: Show the collection's title in the toolbar (3.17 KB, patch)
2015-03-17 20:28 UTC, Debarshi Ray 		none Details | Review
mainToolbar: Show the collection's title in the toolbar (3.15 KB, patch)
2015-03-17 20:47 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2015-03-17 20:22:43 UTC 
Another fall out from bug 686461

We need to unset the custom title otherwise the collection's name will never show up as a label.
Comment 1 Debarshi Ray 2015-03-17 20:27:49 UTC 
Created attachment 299635 [details] [review]
embed: Fix typo
Comment 2 Debarshi Ray 2015-03-17 20:28:16 UTC 
Created attachment 299636 [details] [review]
mainToolbar: Show the collection's title in the toolbar
Comment 3 Cosimo Cecchi 2015-03-17 20:40:20 UTC 
Review of attachment 299635 [details] [review]:

Oops... Looks good
Comment 4 Cosimo Cecchi 2015-03-17 20:41:34 UTC 
Review of attachment 299636 [details] [review]:

::: src/mainToolbar.js
@@ +230,3 @@
+                    }));
+            }
+                this._collBackButton.show();

No need for if (!item) here, since that condition is already covered by the else block
Comment 5 Debarshi Ray 2015-03-17 20:47:00 UTC 
Created attachment 299644 [details] [review]
mainToolbar: Show the collection's title in the toolbar
Comment 6 Cosimo Cecchi 2015-03-17 20:50:00 UTC 
Review of attachment 299644 [details] [review]:

Yes