After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746336 - remove the overlay timeout in dispose
remove the overlay timeout in dispose
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
unspecified
Other Linux
: Normal blocker
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-17 11:09 UTC by Matthias Clasen
Modified: 2015-03-20 18:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
clear timeout on dispose (787 bytes, patch)
2015-03-19 20:11 UTC, Felix Riemann 		accepted-commit_after_freeze Details | Review

Description Matthias Clasen 2015-03-17 11:09:04 UTC 
It looks like EogScrollView does not remove its overlay timeout in dispose.

We are seeing crash reports that seem to indicate this is a problem:

https://retrace.fedoraproject.org/faf/problems/750446/
Comment 1 Felix Riemann 2015-03-19 19:57:23 UTC 
I wonder how this didn't trigger on my system all the time. :(

But yes, it's reproducable with a delay on application shutdown.
Comment 2 Felix Riemann 2015-03-19 20:11:54 UTC 
Created attachment 299871 [details] [review]
clear timeout on dispose

Okay, it's easily reproducable when working with multiple windows.
Thanks for the fix suggestion.

I'll send a freeze break request.
Comment 3 Felix Riemann 2015-03-19 20:14:36 UTC 
Raising severity as this is serious due to the occurrence in multi-window use cases.
Comment 4 Felix Riemann 2015-03-20 18:42:17 UTC 
commit 4153c8a6c7628e2b6cc3dbb7ef062590c7cedf0e
Author: Felix Riemann <>
Date:   Thu Mar 19 21:04:17 2015 +0100

    EogScrollView: Clear overlay timeout on dispose
    
    Fixes segfaults when closing one of multiple EogWindows or when
    application shutdown is delayed.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=746336
---
This problem has been fixed in the unstable development version. The fix will be available in the next major software release.