After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746310 - Use HTTPS for Wikipedia links
Use HTTPS for Wikipedia links
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-16 20:29 UTC by Marcus Lundblad
Modified: 2015-03-20 19:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use HTTPS for Wikipedia links (870 bytes, patch)
2015-03-16 20:35 UTC, Marcus Lundblad 		reviewed Details | Review
placeBubble: Use HTTPS for Wikipedia links. (868 bytes, patch)
2015-03-17 21:08 UTC, Marcus Lundblad 		none Details | Review
placeBubble: Use HTTPS for Wikipedia links. (989 bytes, patch)
2015-03-17 21:11 UTC, Marcus Lundblad 		committed Details | Review

Description Marcus Lundblad 2015-03-16 20:29:47 UTC 
Similar to https://bugzilla.gnome.org/show_bug.cgi?id=741409 we should probably use HTTPS for Wikipedia links.
Comment 1 Marcus Lundblad 2015-03-16 20:35:04 UTC 
Created attachment 299552 [details] [review]
Use HTTPS for Wikipedia links
Comment 2 Mattias Bengtsson 2015-03-17 13:52:05 UTC 
Review of attachment 299552 [details] [review]:

Yes, definitely.

::: src/placeBubble.js
@@ +89,1 @@
                                                                    tokens[1] ]);

Alignment.
Comment 3 Marcus Lundblad 2015-03-17 21:08:49 UTC 
Created attachment 299648 [details] [review]
placeBubble: Use HTTPS for Wikipedia links.
Comment 4 Marcus Lundblad 2015-03-17 21:11:40 UTC 
Created attachment 299649 [details] [review]
placeBubble: Use HTTPS for Wikipedia links.
Comment 5 Jonas Danielsson 2015-03-18 08:40:09 UTC 
Review of attachment 299649 [details] [review]:

Thanks!

Looks fine.
Comment 6 Jonas Danielsson 2015-03-20 19:10:59 UTC 
Attachment 299649 [details] pushed as cdec29e - placeBubble: Use HTTPS for Wikipedia links.