GNOME Bugzilla – Bug 746274
flvdemux: Less spam from no_more_pads warning
Last modified: 2015-03-16 12:05:28 UTC
These warnings can get rather spammy for such a high log level. Patches follow.
Created attachment 299494 [details] [review] patch 1/2
Created attachment 299495 [details] [review] patch 2/2
Aah, wrong patch 2. One moment, please.
Created attachment 299496 [details] [review] patch 2/2
Created attachment 299497 [details] [review] Makes the threshold a #define
Review of attachment 299494 [details] [review]: Good.
Review of attachment 299496 [details] [review]: Looks good except for these small details. Though, I'm wondering why is this a warning is the first place ? Can't an FLV be audio or video only ? ::: gst/flv/gstflvdemux.c @@ +925,3 @@ GST_LOG_OBJECT (demux, "parsing an audio tag"); + if G_UNLIKELY (!demux->audio_pad && demux->no_more_pads) { Add ifndef GST_DISABLE_DEBUG here, so we don't have this if if there is not debug. @@ +1328,3 @@ GST_LOG_OBJECT (demux, "parsing a video tag"); + if G_UNLIKELY (!demux->video_pad && demux->no_more_pads) { same.
Review of attachment 299497 [details] [review]: Yeah, that cleaner. I think I kind of found the answer of my question in the previous comment.
Created attachment 299499 [details] [review] patch 2/2
Review of attachment 299499 [details] [review]: Good.
Thanks for the patches.
Comment on attachment 299494 [details] [review] patch 1/2 commit f2a1f74cecbe20688bf72d627c5ec0fe0534324e Author: Jan Alexander Steffens (heftig) <jsteffens@make.tv> Date: Tue Jan 20 10:18:29 2015 +0100 flvdemux: Fix warning to contain 'video' https://bugzilla.gnome.org/show_bug.cgi?id=746274
Comment on attachment 299497 [details] [review] Makes the threshold a #define commit ac8a27238145f64eabf89f6ab94b0a65fdc56e18 Author: Jan Alexander Steffens (heftig) <jsteffens@make.tv> Date: Mon Mar 16 11:23:52 2015 +0100 flvdemux: Introduce constant for no-more-pads threshold https://bugzilla.gnome.org/show_bug.cgi?id=746274
Comment on attachment 299499 [details] [review] patch 2/2 commit be8e3196a3e236c4f668d761138e3119dc68f0ce Author: Jan Alexander Steffens (heftig) <jsteffens@make.tv> Date: Tue Jan 20 10:18:56 2015 +0100 flvdemux: Don't repeatedly warn after no_more_pads (v2) This can get rather spammy for such a high log level. Only warn once per stream. https://bugzilla.gnome.org/show_bug.cgi?id=746274