After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746263 - wacom: allow button mapping if the stylus has one button too
wacom: allow button mapping if the stylus has one button too
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Wacom
unspecified
Other All
: Normal normal
: ---
Assigned To: Carlos Garnacho
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-15 23:12 UTC by Benjamin Tissoires
Modified: 2015-03-16 11:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wacom: allow button mapping if the stylus has one button too (1.63 KB, patch)
2015-03-15 23:12 UTC, Benjamin Tissoires
none Details | Review
wacom: allow button mapping if the stylus has one button too (1.66 KB, patch)
2015-03-16 00:56 UTC, Benjamin Tissoires
committed Details | Review

Description Benjamin Tissoires 2015-03-15 23:12:15 UTC
Seen on tablets with only one button and on the airbrush tool.

The button mapping combo box does not work :(
Comment 1 Benjamin Tissoires 2015-03-15 23:12:18 UTC
Created attachment 299473 [details] [review]
wacom: allow button mapping if the stylus has one button too

With the airbrush tool which has only one button, the button mapping
combo box does not work.
We should not bail out if the widget has been removed, that means that
the stylus does not support the second button.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Comment 2 Benjamin Tissoires 2015-03-16 00:56:37 UTC
Created attachment 299477 [details] [review]
wacom: allow button mapping if the stylus has one button too

The v1 of the patch broke 2 buttons setting. Actually retrieve
the number of buttons before looking for the UI.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Comment 3 Bastien Nocera 2015-03-16 11:57:14 UTC
Pushed to gnome-3-8 and later branches.