GNOME Bugzilla – Bug 746235
Improve the icons used in the Source View
Last modified: 2018-05-24 18:29:46 UTC
Created attachment 299442 [details] example icons that could be revised Issue moved from my plugin to here: - https://github.com/fossfreedom/alternative-toolbar/issues/8#issuecomment-80918572 tldr; would the maintainers of rhythmbox be interested in merging some source file patches that will revise the icons used to describe the various sources as per the attachment? The Ozon distro maintainer will supply each of the icons. I will try to actually provide the patches for each of the source file ... but may need help for one or two of the tricky ones such as "Import Error..." copied text: "First - "Play queue" uses documents icon. It should use custom symbolic icon, because there is no queue one in the icon themes. Second - "Import errors" misses an icon and it should use - "dialog-error-symbolic.svg" icon. Third - "libre.fm" service icon is very similar to wifi logo, so it should use "network-wireless-symbolic.svg" Fourth - "Radio" needs a custom symbolic icon, because icon sets don't come with radio symbolic icons. Using a server symbolic icon is really confusing. I can do one. Fifth - playlists should not look a search symbolic icon, but custom icons for the three default ypes of playlists. I will do them. a playlists icon. Also - for user created list a playlist icon should be used. Alas for some odd reasons iconsets don't ship with such icon, so I will have to do a custom one."
I am me4oslav from github (georgi from Numix and Ozon) and I am willing to do the needed symbolic icons.
By all means, go ahead then. I'm not really sure what I'm being asked here.
I've done the icons and set them to foss.freedom for implementation. :)
Created attachment 299459 [details] proposed new icons looks good georgi, I've uploaded these anyway so that Jonathan can have a first look. I'll look at the code itself to see if I can figure out what needs changing. "When implementing them please put them in the same scalable subfolders as they are in the tarball and don't change the names. The folders structures and naming are XDG Gnome standards approved, so icon themes can theme them. Rationale: "Play queue" - "mimetypes/audio-x-queue-symbolic.svg" (in the tarball). "Import errors" - "dialog-error-symbolic.svg" (no need for a custom icon). "libre.fm" - "apps/librefm.svg" (in the tarball) "Radio" - "devices/audio-radio.svg" (in the tarball). "User created playlist" - "mimetypes/audio-x-playlist-symbolic.svg" (in the tarball). "Top rated playlist" - "user-bookmarks-symbolic.svg" (no need for a custom icon). "Recently added playlist" - "mimetypes/audio-x-playlist-recently-added-symbolic.svg" (in the tarball). "Recently played playlist" - "mimetypes/audio-x-playlist-recently-played-symbolic.svg" (in the tarball). Everything else is fine."
We can't currently do different icons for each playlist, and I don't like the idea of having special icons for the initial set of playlists, but not allowing user created playlists the same option. The initial playlists aren't any different to user created playlists. The only icon I can see on the libre.fm site at all is the favicon, which doesn't quite look like that. Using a generic icon that looks sort of like it doesn't seem like a good idea to me. I'm not sure what the radio icon is supposed to be. I don't think there's a physical object that meaningfully signifies what 'radio' means in this case.
1) Well, we can use "mimetypes/audio-x-playlist-symbolic.svg" for all playlists, then. 2) Will fix. 3) It is an radio like this one - http://www.visiradio.lv/visiradio-icon.png which makes a lot more sense than a server icon.
[OK] mimetypes/audio-x-playlist-symbolic.svg [OK] mimetypes/audio-x-playlist-recently-played-symbolic.svg [OK] mimetypes/audio-x-playlist-recently-added-symbolic.svg The above 3 icons look good. But as mentioned in "comment 5", "recently-played / recently-added" are just "names" given to the automatic playlists. So, that part is tricky, though I like the idea of using "timer" icons for "recent" operations. "playlist-symbolic" is fine, though I am having slight rendering issues when displayed in rhythmbox ( Refer screenshot ).
Created attachment 340266 [details] Screenshot: Displaying side pane with new icons
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/1401.