After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746231 - Fails when GI_SCANNER_DISABLE_CACHE is set
Fails when GI_SCANNER_DISABLE_CACHE is set
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: g-ir-scanner
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-03-15 06:18 UTC by Garrett Regier
Modified: 2015-04-19 20:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
scanner: Don't fail when GI_SCANNER_DISABLE_CACHE is set (1.45 KB, patch)
2015-03-15 06:21 UTC, Garrett Regier 		accepted-commit_now Details | Review
scanner: Don't fail when GI_SCANNER_DISABLE_CACHE is set (1.45 KB, patch)
2015-04-19 20:11 UTC, Dieter Verfaillie 		none Details | Review

Description Garrett Regier 2015-03-15 06:18:34 UTC 
I have to set GI_SCANNER_DISABLE_CACHE because the cache store tends to fail with parallel builds: https://bugzilla.gnome.org/show_bug.cgi?id=620187

However, g-ir-scanner assumes that the cache store is always working. With this patch I have been able to run gobject-introspection `make check` many times without seeing the same failure.

This also has the effect of removing a round-trip to the cache store, so should increase performance a bit.
Comment 1 Garrett Regier 2015-03-15 06:21:16 UTC 
Created attachment 299439 [details] [review]
scanner: Don't fail when GI_SCANNER_DISABLE_CACHE is set

It was assumed that cache store was always working, this
also removes a round trip to the cache store. So performance
should also get a small boost.
Comment 2 Garrett Regier 2015-04-10 21:49:01 UTC 
ping? This is very annoying, especially when working on gobject-introspection.
Comment 3 Dieter Verfaillie 2015-04-10 22:12:17 UTC 
Review of attachment 299439 [details] [review]:

LGTM
Comment 4 Dieter Verfaillie 2015-04-19 20:11:48 UTC 
The following fix has been pushed:
cc6ef77 scanner: Don't fail when GI_SCANNER_DISABLE_CACHE is set
Comment 5 Dieter Verfaillie 2015-04-19 20:11:52 UTC 
Created attachment 301944 [details] [review]
scanner: Don't fail when GI_SCANNER_DISABLE_CACHE is set

It was assumed that cache store was always working, this
also removes a round trip to the cache store. So performance
should also get a small boost.

https://bugzilla.gnome.org/show_bug.cgi?id=746231
Signed-off-by: Garrett Regier <garrett.regier@riftio.com>