GNOME Bugzilla – Bug 746219
Some applications appear as "..." in the app grid
Last modified: 2015-03-25 13:49:18 UTC
Created attachment 299419 [details] screenshot See attached screenshot; that application is actually Google Chrome beta.
That probably means that the .desktop file specifies an icon name (so no fallback to 'application-x-executable'), but it cannot be resolved to an actual icon. The empty icon texture is supposed to have the correct size anyway, but something's failing ...
Created attachment 299421 [details] [review] StIcon: split loading of pending texture in separate function This will be more useful later.
Created attachment 299422 [details] [review] StIcon: add a fallback-icon-name property This can be used when the lookup for the specified icon fails, in case the client doesn't want an empty texture.
Created attachment 299423 [details] [review] ShellApp: use st_icon_set_fallback_icon_name() to specify app fallback We can now safely pass a NULL GIcon to st_icon_set_gicon(), and specify a more generic fallback using the new API we just introduced.
(In reply to Florian Müllner from comment #1) > That probably means that the .desktop file specifies an icon name (so no > fallback to 'application-x-executable'), but it cannot be resolved to an > actual icon. The empty icon texture is supposed to have the correct size > anyway, but something's failing ... An empty icon texture wouldn't be much better to be fair... I implemented a more generic fallback to application-x-executable in the attached patchset.
Review of attachment 299421 [details] [review]: Not sure about this one - the new function looks misnamed to me, and the split seems completely irrelevant for the following patches. ::: src/st/st-icon.c @@ +394,3 @@ } + load_pending_texture (icon); ... except that it's more setup_stuff_to_replace_icon_texture_when_ready, the actual loading was already done above?
Review of attachment 299422 [details] [review]: LGTM
Review of attachment 299423 [details] [review]: Nice!
Attachment 299422 [details] pushed as c7185d5 - StIcon: add a fallback-icon-name property Attachment 299423 [details] pushed as f812e9b - ShellApp: use st_icon_set_fallback_icon_name() to specify app fallback Yeah, the patchset still works without that patch. I pushed the other two to master.
*** Bug 746739 has been marked as a duplicate of this bug. ***