After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746214 - Partition naming enhancements
Partition naming enhancements
Status: RESOLVED FIXED
Product: gparted
Classification: Other
Component: application
GIT HEAD
Other Linux
: Normal normal
: ---
Assigned To: gparted maintainers alias
gparted maintainers alias
Depends on:
Blocks:
 
 
Reported: 2015-03-14 15:49 UTC by Mike Fleetwood
Modified: 2015-08-03 17:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Partition naming enhancements (draft 1) (19.75 KB, patch)
2015-03-14 16:29 UTC, Mike Fleetwood
none Details | Review
Partition naming enhancements (v1) (29.68 KB, patch)
2015-03-18 20:00 UTC, Mike Fleetwood
none Details | Review
Partition naming enhancements (v2) (29.45 KB, patch)
2015-03-24 19:03 UTC, Mike Fleetwood
none Details | Review

Description Mike Fleetwood 2015-03-14 15:49:36 UTC
Going to add the following enhancements to partition naming:
1) Allow partition naming on busy partitions
2) Make support of naming for other partition table types possible
3) Preserve partition name in preview of format operation
   (Currently the name blanks in the preview)

Optionally:
1) Add partition name to the Create new Partition dialog.  Make
   sensitive depending on whether the partition table type supports
   naming or not.  Make the right hand side of the dialog look like
   this:
                Create as:        [Primary|Logical|Extended|v]
    (New)       Partition name:   [                          ]
                File system:      [btrfs|ext2|ext3|...     |v]
                Label:            [                          ]
Comment 1 Mike Fleetwood 2015-03-14 16:29:58 UTC
Created attachment 299409 [details] [review]
Partition naming enhancements (draft 1)

Hi Curtis,

Here's draft patchset for this.

Added the partition name entry box to the create new partition dialog
so you can see what it looks like.  Doesn't actually do anything yet
though.  There is deliberately a slight extra gap between partition name
entry row and file system combobox row.  (Previously the dialog had one
between the file system comboxbox row and the label entry row).

Please have a look at the running dialog and let me know what you think.
Are you specifically against it, or for it from a UI point of view?

Thanks,
Mike
--8<--
File: gparted-746214-partition-names-d1.mbox
Desc: Partition naming enhancements (draft 1)
submitted: submitted-partition-names-d1
Comment 2 Mike Fleetwood 2015-03-18 20:00:28 UTC
Created attachment 299757 [details] [review]
Partition naming enhancements (v1)

Hi Curtis,

Here's patchset v1.

Compared to draft 1, it fully implements adding the partition name to
the Create New Partition dialog.

Ready for testing and inclusion after the GParted 0.22.0 release.

Thanks,
Mike
Comment 3 Mike Fleetwood 2015-03-24 19:03:57 UTC
Created attachment 300220 [details] [review]
Partition naming enhancements (v2)

Hi Curtis,

Here's patchset v2.

The only difference is a few pixels in the layout of the create new
partition dialog.  Compare comments of patch number 7/8 between v1 and
v2 for details.

Thanks,
Mike
Comment 4 Curtis Gedak 2015-03-25 19:16:43 UTC
Hi Mike,

My testing of patch set v2 in comment #3 went surprisingly smooth.  The code looks clean, and I did not encounter a single problem in my testing.  Great work!

I confirmed the following changes:

1) Busy GPT partitions can have their name changed
2) When formating a GPT partition, the existing partition name is shown
   in the preview of the format operation.
3) The "create new partition" dialog now contains a "Partition name" entry.
   This entry was available for GPT, and greyed out for msdos partition
   tables.

As such I have committed patch set v2 for inclusion in the next release of GParted.

The relevant git commits can be viewed at the following links:

Allow partition naming on busy partitions (#746214)
https://git.gnome.org/browse/gparted/commit/?id=f804bc3244c1ee4509fe02b66990709566b69d08

Make support of naming for other partition table types possible (#746214)
https://git.gnome.org/browse/gparted/commit/?id=9b2c95bcd176e8507758811e64e56ed7655a3b1e

Preserve partition name in preview of format operation (#746214)
https://git.gnome.org/browse/gparted/commit/?id=eae2dbaa8290b34b1f7aab1bfd1f1adaea269bc6

Rename member object to filesystem_label_entry (#746214)
https://git.gnome.org/browse/gparted/commit/?id=fc599270c2562e4d139104e1bbb84c935086bc8a

Remove redundant Gtk::Entry calls in Create New Partition dialog
https://git.gnome.org/browse/gparted/commit/?id=650f4c7f20bae5236be1bacd6f79a4f1b2a69e13

Pass Device object when setting up Dialog_Partition_New (#746214)
https://git.gnome.org/browse/gparted/commit/?id=6a9a06af0ead394d05657b4b57c5b35852282e61

Add partition name to Create New Partition dialog (#746214)
https://git.gnome.org/browse/gparted/commit/?id=5fd7c926710ef831cdd8ea51990a64cc50af85ab

Name partitions as required when creating a new partition (#746214)
https://git.gnome.org/browse/gparted/commit/?id=8d005aff1a33186df2bffa09e9fc6032fdac785e
Comment 5 Curtis Gedak 2015-08-03 17:29:45 UTC
This enhancement was included in the GParted 0.23.0 release on August 3, 2015.