After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746182 - wacom: add a new icon for stylii without an eraser
wacom: add a new icon for stylii without an eraser
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: wacom
unspecified
Other All
: Normal normal
: ---
Assigned To: Carlos Garnacho
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-13 21:06 UTC by Benjamin Tissoires
Modified: 2015-04-01 09:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wacom: add a new icon for stylii without an eraser (1.63 KB, patch)
2015-03-13 21:06 UTC, Benjamin Tissoires 		committed Details | Review

Description Benjamin Tissoires 2015-03-13 21:06:44 UTC 
g-c-c will handle devices without an eraser.
We can adapt the UI with an icon which does not have
the eraser, but g-s-d needs to be updated first.
Comment 1 Benjamin Tissoires 2015-03-13 21:06:47 UTC 
Created attachment 299359 [details] [review]
wacom: add a new icon for stylii without an eraser
Comment 2 Bastien Nocera 2015-03-19 14:19:34 UTC 
Review of attachment 299359 [details] [review]:

Looks good otherwise.

::: plugins/wacom/gsd-wacom-device.c
@@ +126,2 @@
 {
+	WacomStylusType type = libwacom_stylus_get_type (wstylus);

Separate the declaration and assignment.
Comment 3 Bastien Nocera 2015-04-01 09:15:12 UTC 
Attachment 299359 [details] pushed as 7620ded - wacom: add a new icon for stylii without an eraser