GNOME Bugzilla – Bug 746171
Headerbar separator looks ugly under Ambiance theme
Last modified: 2015-03-13 21:10:13 UTC
The separator between the two halves of the headerbar looks fat and too bright under Ambiance, especially when compared to the svelte look it has in Adwaita. The problem seems to be that Ambiance makes separators in the headerbar mostly transparent. When the separator is in a Gtk.Headerbar, this looks good. But we have it in a Gtk.Box, so it's being mostly transparent over a white background, which isn't so good. One possibility would be to move that separator inside the left-hand headerbar, so it gets the expected color. This would require us to stick in a few pixel offset in the sizing to get it to line up with the paned handle. When I tried having two headerbars abut in another situation, I found a barely-visible seam where they joined. But this might be okay if it's right next to a separator.
Created attachment 299354 [details] [review] Use separator within Gtk.Headerbar in MainToolbar This uses the separator within the Gtk.Headerbar trick. We have to put in a manual offset to get the separator to line up. This 6px value is right for both Ambiance and Adwaita, but I don't know that it's universal. In Ambiance, there's a slight seam visible where the two headerbars meet, but it's less bad than the previous appearance. Two changes that may be of concern: - The separator no longer spans the entire header height -- there's some padding on the top and bottom. This looks okay as is, but it will be inconsistent with other applications that use the split headerbar. - There's more padding on the right of the separator than the left, due to the padding at the end and start of the two headerbars. This doesn't look so bad, since the separator lines up with the left-hand side of the paned handle. We could also add matching padding on the left of the separator. I'm on the fence about this one. It does improve the appearance under Ambiance, but it looks slightly worse under other themes and saddles us with this hack for some time.
Review of attachment 299354 [details] [review]: This looks tremendously better under Unity. I know it's hacky but the improvement tells me that it's worth it. Please add brief comments explaining what this is doing and a link to this ticket so, in the future, we (or someone) can remove it when/if Unity gets this fixed.
Attachment 299354 [details] pushed as 55ecbb6 - Use separator within Gtk.Headerbar in MainToolbar