After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746168 - [glshader] OSX crashes when trying to get vertex attribute without vertex shader
[glshader] OSX crashes when trying to get vertex attribute without vertex shader
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2015-03-13 17:17 UTC by Michał Dębski
Modified: 2015-03-13 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

add_check_for_vertex_shader.patch (1006 bytes, patch)
2015-03-13 17:17 UTC, Michał Dębski
none Details | Review

Description Michał Dębski 2015-03-13 17:17:30 UTC
Created attachment 299342 [details] [review]

GetAttribLocation should return -1 when there is no such attribute but it's crashing.

Backtrace from glfiltersobel:

frame #0: 0x000000010231faf1 libgstgl-1.0.0.dylib`gst_gl_shader_get_attribute_location(shader=0x0000000101080100, name=0x000000010233d54a) + 177 at gstglshader.c:1175
    frame #1: 0x0000000102318991 libgstgl-1.0.0.dylib`_get_attributes(filter=0x00000001018040d0) + 81 at gstglfilter.c:1412
    frame #2: 0x0000000102318911 libgstgl-1.0.0.dylib`gst_gl_filter_render_to_target_with_shader(filter=0x00000001018040d0, resize=1, input=8, target=3, shader=0x0000000101080100) + 49 at gstglfilter.c:1442
    frame #3: 0x00000001004bd165`gst_gl_filtersobel_filter_texture(filter=0x00000001018040d0, in_tex=8, out_tex=6) + 85 at gstglfiltersobel.c:234
    frame #4: 0x000000010231845c libgstgl-1.0.0.dylib`gst_gl_filter_filter_texture(filter=0x00000001018040d0, inbuf=0x000000010108f0a0, outbuf=0x000000010108f1b0) + 972 at gstglfilter.c:1262
    frame #5: 0x000000010231be0f libgstgl-1.0.0.dylib`gst_gl_filter_transform(bt=0x00000001018040d0, inbuf=0x000000010108f0a0, outbuf=0x000000010108f1b0) + 367 at gstglfilter.c:1309

Thanks to Matthew for catching the cause on first look.
Comment 1 Matthew Waters (ystreet00) 2015-03-13 17:42:16 UTC

commit 40a4530c5d1ddb7625ccc9ee6e95e5c044db29f7
Author: Neos3452 <>
Date:   Fri Mar 13 17:04:17 2015 +0000

    glshader: prevent from getting attributes without vertex shader
    It doesn't make sense to query for vertex attributes without a vertex
    shader. Moreover this is causing a crash on OSX.