After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746142 - tests: Add unit test for alpha manipulation in video-converter
tests: Add unit test for alpha manipulation in video-converter
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-13 11:12 UTC by RaviKiran
Modified: 2018-11-03 11:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
unit test case for alpha (10.19 KB, patch)
2015-03-13 11:14 UTC, RaviKiran 		none Details | Review
unit test case for alpha (6.75 KB, patch)
2015-03-27 08:59 UTC, RaviKiran 		needs-work Details | Review

Description RaviKiran 2015-03-13 11:12:18 UTC 
Add unit test for alpha manipulation in video-converter.
Comment 1 RaviKiran 2015-03-13 11:14:56 UTC 
Created attachment 299301 [details] [review]
unit test case for alpha

Attached unit test case. Pls review.
Comment 2 Tim-Philipp Müller 2015-03-13 12:01:45 UTC 
More unit tests, excellent!
Comment 3 Reynaldo H. Verdejo Pinochet 2015-03-26 22:41:05 UTC 
Comment on attachment 299301 [details] [review]
unit test case for alpha

> [...]
>+
>+  out_data = GST_VIDEO_FRAME_PLANE_DATA (&outframe, 0);
>+  out_bpp = GST_VIDEO_FRAME_COMP_PSTRIDE (&outframe, 0);
>+
>+#if G_BYTE_ORDER == G_LITTLE_ENDIAN

From a quick glance at the code I'd suggest
ifdefing out_bpp += 3 on != G_LITTLE_ENDIAN
(or similar) once and drop all the other ifdefs.
Quite Shorter and a lot cleaner this way.
Comment 4 RaviKiran 2015-03-27 08:59:33 UTC 
Created attachment 300420 [details] [review]
unit test case for alpha

Thanks. Modified it.
Comment 5 Tim-Philipp Müller 2017-12-09 15:09:00 UTC 
This seems to fail for me though - does it rely on other patches?

libs/video.c:2613:F:general:test_video_convert_alpha:0: 'out_data[i * out_bpp + alpha_offset]' (186) is not equal to '0x7F' (127)
C
Comment 6 GStreamer system administrator 2018-11-03 11:35:56 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/173.