After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746113 - gsd-list-wacom still looks for the dconf key "display"
gsd-list-wacom still looks for the dconf key "display"
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: wacom
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: Carlos Garnacho
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-12 20:23 UTC by Benjamin Tissoires
Modified: 2015-03-13 15:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wacom: Remove use of removed "display" settings key (1.96 KB, patch)
2015-03-13 08:41 UTC, Bastien Nocera
committed Details | Review
wacom: Remove handling of moved "display" key (1.31 KB, patch)
2015-03-13 08:41 UTC, Bastien Nocera
committed Details | Review

Description Benjamin Tissoires 2015-03-12 20:23:43 UTC
Running /usr/libexec/gsd-list-wacom:

Device 'Wacom Intuos5 touch S' (type: Pad)
	Reversible: yes
	Screen Tablet: no
	Integrated Device: no
	Unknown (fallback) device: no
	Generic settings: schema-id: org.gnome.settings-daemon.peripherals.wacom (path: /org/gnome/settings-daemon/peripherals/wacom/2bc5be1c122942399ff2573130be2050-usb:056a:0026:Wacom Intuos5 touch S Pad/)

(gsd-list-wacom:2868): GLib-GIO-ERROR **: Settings schema 'org.gnome.settings-daemon.peripherals.wacom' does not contain a key named 'display'
Trace/breakpoint trap (core dumped)

The key "display" has been removed in f867268 (schemas: Remove "display" setting from wacom devices' schema) but list-wacom.c was not updated accordingly.

I *think* only list-wacom.c still looks for this keys, but that would be better if someone else double checks that g-s-d does not use it anywhere else.
Comment 1 Bastien Nocera 2015-03-13 08:41:42 UTC
Created attachment 299270 [details] [review]
wacom: Remove use of removed "display" settings key

The display key moved from the Wacom specific schema, to a more generic
one. Read the EDID from the generic one.
Comment 2 Bastien Nocera 2015-03-13 08:41:47 UTC
Created attachment 299271 [details] [review]
wacom: Remove handling of moved "display" key

The "display" key was moved, so it's not in our schema anymore.
Comment 3 Carlos Garnacho 2015-03-13 12:51:08 UTC
Doh, I wonder how I missed those, I indeed checked for the removed settings when the shuffling happened. Both patches look fine indeed.
Comment 4 Bastien Nocera 2015-03-13 15:08:04 UTC
Attachment 299270 [details] pushed as 50e5dc1 - wacom: Remove use of removed "display" settings key
Attachment 299271 [details] pushed as 7dcc002 - wacom: Remove handling of moved "display" key