After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746061 - Ensure the headerbar is visible for all detached composers
Ensure the headerbar is visible for all detached composers
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Geary Maintainers
Geary Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-12 01:40 UTC by Robert Schroll
Modified: 2015-03-12 01:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Ensure the headerbar is visible for all detached composers (3.80 KB, patch)
2015-03-12 01:40 UTC, Robert Schroll 		committed Details | Review

Description Robert Schroll 2015-03-12 01:40:27 UTC 
If you create a new composer and then detach it, it doesn't get the 
headerbar put below the titlebar.  We used to be able to assume it was 
always present when the ComposerWindow got it, but that's no longer the 
case.
Comment 1 Robert Schroll 2015-03-12 01:40:30 UTC 
Created attachment 299143 [details] [review]
Ensure the headerbar is visible for all detached composers

It used to be that all embeded composers had the headerbar inside
themselves, so the ComposerWindow only had to remove it if necessary.
But the new new-composer state doesn't have this, so we have to be
sure.  To assist in this, the ComposerWidget now has embed_header() and
free_header() methods.
Comment 2 Jim Nelson 2015-03-12 01:41:48 UTC 
Review of attachment 299143 [details] [review]:

Commit!
Comment 3 Robert Schroll 2015-03-12 01:42:27 UTC 
Attachment 299143 [details] pushed as 221c196 - Ensure the headerbar is visible for all detached composers