After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746027 - Timer notification reappears in notification area after reboot/relogin
Timer notification reappears in notification area after reboot/relogin
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: Unknown User
Unknown User
Depends on:
Blocks: 744927
 
 
Reported: 2015-03-11 12:33 UTC by Lukas Brabec
Modified: 2015-03-12 16:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
calendar: Only show close button on messages that can be cleared (1.99 KB, patch)
2015-03-11 22:29 UTC, Florian Müllner
committed Details | Review
calendar: Add public close() method (1.54 KB, patch)
2015-03-11 22:29 UTC, Florian Müllner
committed Details | Review
calendar: Close messages on clear (2.09 KB, patch)
2015-03-11 22:29 UTC, Florian Müllner
committed Details | Review

Description Lukas Brabec 2015-03-11 12:33:06 UTC
Gnome Clocks timer yields notification when countdown finishes. When dismissing all notifications using the cross icon next to 'Notifications' header, the countdown notification reappears after reboot or relogin. However, dismissing this notification by clicking on it or using its cross icon works as expected.

1. Boot Fedora 22 with gnome-shell-3.15.91-1.fc22.x86_64
2. Start Gnome Clocks, go to Timer
3. Set and start timer
4. Notification is shown after countdown finishes
5. Open Notifications and dismiss all notifications using the cross icon
6. Reboot or relogin
7. Countdown notification is still present
Comment 1 Florian Müllner 2015-03-11 22:29:32 UTC
Created attachment 299135 [details] [review]
calendar: Only show close button on messages that can be cleared

Currently closing all messages is subtly different from clearing
a section, which is confusing. Start making the behavior more
predictable by only showing a close button in the message when
the section's clear button would remove it.
Comment 2 Florian Müllner 2015-03-11 22:29:39 UTC
Created attachment 299136 [details] [review]
calendar: Add public close() method

Currently a message can only be closed by its close button. However
as we want to make a section's clear action synonymous with clicking
the close button of each individual message in the list, we will need
to expose the close action, so add a corresponding method.
Comment 3 Florian Müllner 2015-03-11 22:29:44 UTC
Created attachment 299137 [details] [review]
calendar: Close messages on clear

Currently the clear action in the section header simply removes all
messages from the section. While the result looks exactly as if the
close button of each individual message had been clicked, the messages
are not actually closed - after a restart (or some other condition that
triggers a reload), the messages simply reappear, which is confusing.
Do the expected thing instead, and make clear close all messages in the
section.
Comment 4 Carlos Soriano 2015-03-12 16:08:46 UTC
Review of attachment 299135 [details] [review]:

OK
Comment 5 Carlos Soriano 2015-03-12 16:09:01 UTC
Review of attachment 299136 [details] [review]:

OK
Comment 6 Carlos Soriano 2015-03-12 16:09:32 UTC
Review of attachment 299137 [details] [review]:

OK
Comment 7 Florian Müllner 2015-03-12 16:33:19 UTC
Attachment 299135 [details] pushed as e72450f - calendar: Only show close button on messages that can be cleared
Attachment 299136 [details] pushed as b61cb92 - calendar: Add public close() method
Attachment 299137 [details] pushed as e4ad31a - calendar: Close messages on clear