After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746003 - segv on opening property dialog on directory on ftp server with "odd" uid
segv on opening property dialog on directory on ftp server with "odd" uid
Status: RESOLVED FIXED
Product: gnome-commander
Classification: Other
Component: networking
1.4.x
Other Linux
: Normal normal
: 1.4
Assigned To: GNOME Commander maintainer(s)
GNOME Commander maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-03-11 01:45 UTC by Mamoru TASAKA
Modified: 2015-03-14 23:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Mamoru TASAKA 2015-03-11 01:45:10 UTC 
Using gnome-commander 1.4.5, when

1. Choose "Connections" -> "Remove Server"
2. Choose "Add".
3. With "Remove Server" dialog, set
  - Service type "Public FTP"
  - Alias "ftp_riken"
  - Server "ftp.riken.jp"
  - Other: left blank
  Now click "OK"
4, On "Remove Server" dialog, choose "ftp_riken", then click "Connect"

5. on ftp_riken, go to the directory "Linux"
6. on "fedora", right-click, then choose "Property"

Now gnome-commander 1.4.5 crash with
ERROR:/builddir/build/BUILD/gnome-commander-1.4.5/_builddir/../src/owner.h:165:const gchar* GnomeCmdOwner::HashTable<T, ID>::operator[](ID) [with T = GnomeCmdOwner::user_t; ID = unsigned int; gchar = char]: assertion failed: (entry != NULL)

Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1200349
Comment 1 Mamoru TASAKA 2015-03-11 01:46:02 UTC 
Backtrace available on:
https://bugzilla.redhat.com/attachment.cgi?id=999816
Comment 2 Mamoru TASAKA 2015-03-11 08:42:35 UTC 
So looks like remove g_assert sentence in
GnomeCmdOwner::HashTable<T,ID>::operator [] (ID id)
cures this issue, but I don't know if it is expected or not.
Comment 3 Uwe Scholz 2015-03-14 23:13:20 UTC 
Thank you very much for your detailed bug report. I could reproduce the described behavior. Iit is okay to remove the g_assert call from GnomeCmdOwner::HashTable<T,ID>::operator in this case, as NULL is returned now for the name of the UID / GID, which itself is captured in src/gnome-cmd-chown-component.cc where the class is used.

I committed your fix, it will go into the next release of GCMD.