GNOME Bugzilla – Bug 745972
update to latest AX_* macros from upstream
Last modified: 2015-04-27 18:49:16 UTC
Most importantly, updating to latest macros will eliminate spurious checks for C++ compiler in configure phase.
Created attachment 299024 [details] [review] build: Updates AX_CHECK_ENABLE_DEBUG macro This update to the macro also eliminates the need to pass $ax_is_release, since it is the default now.
Created attachment 299025 [details] [review] build: Updates AX_COMPILER_FLAGS macro This update, most importantly, removes the C++ compiler checks during configure phase. Additionally, it also eliminates the need to pass $ax_is_release, since it is the default one now.
Created attachment 299026 [details] [review] build: Updates all AX_* macros from upstream
Review of attachment 299024 [details] [review]: ::: configure.ac @@ +18,3 @@ AX_IS_RELEASE([git-directory]) +AX_CHECK_ENABLE_DEBUG([yes],,,) I would prefer to retain the $ax_is_release parameter, unless we don't need to call AX_IS_RELEASE any more, which I don't think is the case. Having it show up in grep avoids any future "why do we need this AX_IS_RELEASE thing" questions, and the examples in https://wiki.gnome.org/Projects/GnomeCommon/Migration have it too.
Created attachment 299032 [details] [review] build: Updates AX_COMPILER_FLAGS macro This update, most importantly, removes the C++ compiler checks during configure phase.
Created attachment 299033 [details] [review] build: Updates all AX_* macros from upstream
Review of attachment 299032 [details] [review]: Thanks for following up on this, Pranav. The thing is that ax_compiler_flags.m4 is not self-contained. AX_COMPILER_FLAGS requires every other M4 file that was a part of commit e38eb7a75f431224d36d4a871ccecb0b83f85fe6 In this case since we are not going to use the C++ compiler, I think we should remove ax_compiler_flags_cflags.m4 from our tree. Therefore we should do all these updates as part of this commit. Here is an example: https://git.gnome.org/browse/yelp/commit/?id=3b9364324d8545b3bce91f83bd55b10b1b5e3c2e We already put AX_COMPILER_FLAGS above AC_PROG_CC, so that part can be ignored.
Review of attachment 299033 [details] [review]: Apart from ax_is_release.m4 and ax_check_enable_debug.m4, everything else should be in the other commit.
Review of attachment 299032 [details] [review]: Oops, I typoed. We should consider removing ax_compiler_flags_cxxflags.m4, not ax_compiler_flags_cflags.m4.
Created attachment 301196 [details] [review] build: Updates AX_COMPILER_FLAGS macro This update, most importantly, removes the C++ compiler checks during configure phase.
Created attachment 301197 [details] [review] build: Updates all AX_* macros from upstream
Review of attachment 301197 [details] [review]: Thanks. Looks good. Minor nitpick: tt should be "Update ...", not "Updates ..." in the commit message.
Review of attachment 301196 [details] [review]: Thanks, Pranav. It would be worth noting that -Waggregate-return is no longer part of the default warning set.
Please push to both master and gnome-3-16.
The following fixes have been pushed: 2d3d50e build: Updates all AX_* macros from upstream d12b708 build: Update AX_COMPILER_FLAGS macro
Created attachment 301233 [details] [review] build: Updates all AX_* macros from upstream
Created attachment 301234 [details] [review] build: Update AX_COMPILER_FLAGS macro This update, most importantly, removes the C++ compiler checks during configure phase.
This update causes error on systems not using bash as /bin/sh because it uses ${flag:5}. Using the latest version of ax_compiler_flags_cflags.m4 can fix this problem.
Created attachment 302263 [details] [review] build: Update AX_COMPILER_FLAGS_CFLAGS macro Prevents error on systems not using bash as /bin/sh.
Review of attachment 302263 [details] [review]: Thanks, Pranav.
Comment on attachment 302263 [details] [review] build: Update AX_COMPILER_FLAGS_CFLAGS macro pushed as 07b35f5 on master pushed as e6650bf on gnome-3-16