After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745970 - notification link colour too close to background colour, hard to read
notification link colour too close to background colour, hard to read
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-10 15:10 UTC by Frederic Peters
Modified: 2015-03-10 19:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
notification with link (6.51 KB, image/png)
2015-03-10 15:10 UTC, Frederic Peters 		  Details
theme: lighten up link color for contrast (692 bytes, patch)
2015-03-10 19:19 UTC, Jakub Steiner 		none Details | Review

Description Frederic Peters 2015-03-10 15:10:06 UTC 
Created attachment 299004 [details]
notification with link

The current link_color seems to be created that way, and it makes a colour that is hard to read (on my screen, with my eyes, but others on irc agreed).

$link_color: if($variant == 'light', darken($selected_bg_color,10%),
                                     lighten($selected_bg_color,20%));

Capture attached.
Comment 1 Jakub Steiner 2015-03-10 15:31:50 UTC 
One would think .shell-link {} is where this would be defined globally. Nope. One would expect .notification-banner .shell-link {} to be specific. Nada.
Comment 2 Florian Müllner 2015-03-10 15:37:35 UTC 
Yeah, it's hardly obvious:

  .url-highlighter { link-color: ... }

Not sure however how we can do much better - the link is not a separate entity, but part of a label (so we need something other than "color") ...
Comment 3 Jakub Steiner 2015-03-10 19:19:23 UTC 
Created attachment 299046 [details] [review]
theme: lighten up link color for contrast