After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745963 - app: Avoid connecting to any "notify" signal for theme changes
app: Avoid connecting to any "notify" signal for theme changes
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-10 12:35 UTC by Kalev Lember
Modified: 2015-03-10 13:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
app: Avoid connecting to any "notify" signal for theme changes (2.70 KB, patch)
2015-03-10 12:36 UTC, Kalev Lember 		committed Details | Review

Description Kalev Lember 2015-03-10 12:35:58 UTC 
12:36 < kalev> mclasen: is there a way to get an app to reload its css theme when the gtk theme changes?
12:38 < pbor> kalev: https://git.gnome.org/browse/gedit/tree/gedit/gedit-app.c#n406
12:39 < pbor> but now that I look at it I do not like that connection to any "notify" :(
12:39 < mclasen> kalev: listen for theme changes, and reload it ?
12:39 < kalev> pbor: thanks!
12:40 < pbor> I guess gtksettings changes rarely enough that it is not so bad
Comment 1 Kalev Lember 2015-03-10 12:36:34 UTC 
Created attachment 298983 [details] [review]
app: Avoid connecting to any "notify" signal for theme changes

Instead, connect to notify::gtk-theme-name.
Comment 2 Paolo Borelli 2015-03-10 13:10:34 UTC 
Review of attachment 298983 [details] [review]:

looks good
Comment 3 Kalev Lember 2015-03-10 13:46:31 UTC 
Attachment 298983 [details] pushed as 1188740 - app: Avoid connecting to any "notify" signal for theme changes