After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745954 - stars turned buttons
stars turned buttons
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-03-10 11:15 UTC by Matthias Clasen
Modified: 2015-03-10 14:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (273.55 KB, image/png)
2015-03-10 11:15 UTC, Matthias Clasen 		  Details
HighContrast: style the stars (1.14 KB, patch)
2015-03-10 12:40 UTC, Matthias Clasen 		none Details | Review
Rebase the HighContrast theme (4.42 KB, patch)
2015-03-10 13:37 UTC, Kalev Lember 		committed Details | Review

Description Matthias Clasen 2015-03-10 11:15:34 UTC 
see screenshot
Comment 1 Matthias Clasen 2015-03-10 11:15:57 UTC 
Created attachment 298973 [details]
screenshot
Comment 2 Matthias Clasen 2015-03-10 11:33:15 UTC 
to reproduce:

1) kill gnome-software
2) switch to HighContrast
3) start gnome-software
4) switch back to Adwaita
Comment 3 Matthias Clasen 2015-03-10 12:40:48 UTC 
Created attachment 298984 [details] [review]
HighContrast: style the stars

This copies the css for stars from gtk-style.css over to
gtk-style-hc.css, so we have nice stars in HighContrast too.
Comment 4 Kalev Lember 2015-03-10 13:34:40 UTC 
Hm, this is definitely not the only place where we've failed to keep the HighContrast theme up to date. I think it would make sense to fully rebase gtk-style-hc.css based on gtk-style.css, so that we get all the latest changes.
Comment 5 Kalev Lember 2015-03-10 13:37:11 UTC 
Created attachment 298994 [details] [review]
Rebase the HighContrast theme

We've failed to keep the HighContrast CSS up to date. This commit
rebases gtk-style-hc.css on top of gtk-style.css. The diff between the
two files is minimal, only removing a few shadows and borders and custom
colours to make the HighContrast style look sharper.
Comment 6 Kalev Lember 2015-03-10 13:39:00 UTC 
How it looks with the patch above: http://kalev.fedorapeople.org/gnome-software-hc-1.png
Comment 7 Kalev Lember 2015-03-10 14:45:29 UTC 
Attachment 298994 [details] pushed as 274576e - Rebase the HighContrast theme