GNOME Bugzilla – Bug 745749
[fdonotificationbackend] Check server's spec version and respond accordingly
Last modified: 2015-04-08 10:32:49 UTC
This is more complex case of https://bugzilla.gnome.org/show_bug.cgi?id=745634 I think that fdonotificationbackend should not always assume than daemon supports 1.2 version of the spec, but maintain backward compatibility. I think fdonotificationbackend should: 1. check spec_version from GetServerInformation. 2. use only tags from returned version. For example use image-path only if spec_version >= 1.2, if 1.2 <= spec_version <= 1.1, use image_path, else use app_icon.
The fdo backend is fully backwards compatible with older versions of the spec, as hints that a server doesn't understand must be ignored. It just means that you don't get an icon in some cases. In general, I'd like to avoid the extra round-trip on the bus if that's possible. Are there really still servers out there that haven't been patched to recognoize 'image-path' as well as 'image_path'? Should we maybe just always use 'image_path', then? As I said in the other bug, we will not support sending the notification icon as 'app_icon', as that is supposed to be the application's icon.
yes, KDE one understand image_path, but not image-path for now. (there is https://bugs.kde.org/show_bug.cgi?id=344885 for understanding image-path) XFCE one does not understand both.
We'll try to push the spec to xdg soon. Closing this bug here. I don't care much about supporting older notification servers. If XFCE's daemon doesn't get patched, it won't have icons. That's an ok regression and saves the majority of users from the extra dbus call.
I've not seen any progress on pushing this to freedesktop.org. It was referenced in the relevant KDE bug that you're not putting this on fd.o because of slow sys admins. You don't need a sysadmin to create a wiki editing account. Anyone with fd.o git access for any repo can create a new wiki account for anyone else see http://wiki.freedesktop.org/sitewranglers/wiki/401/.