GNOME Bugzilla – Bug 745736
goc-line: start-arrow overlayed by line
Last modified: 2015-03-06 16:00:14 UTC
Created attachment 298702 [details] start-arrow Hi all, i wonder whether it's intended that the 'start-arrow' is overlayed by the line. At least for my application it doesn't make sense (see the attached picture). Since aligning the code to my needs was stupidly simple i don't know whether it's a bug or it's an intended behavior!? Here is the code diff that yields the new behavior: diff --git primary:goffice/canvas/goc-line.c master:goffice/canvas/goc-line.c index 30946cd..88f2a9a 100644 --- primary:goffice/canvas/goc-line.c +++ master:goffice/canvas/goc-line.c @@ -260,7 +260,7 @@ goc_line_draw (GocItem const *item, cairo_t *cr) if ((endx != 0. || endy!= 0.) && go_styled_object_set_cairo_line (GO_STYLED_OBJECT (item), cr)) { /* try to avoid horizontal and vertical lines between two pixels */ - cairo_move_to (cr, 0., 0.); + cairo_move_to (cr, startx, starty); cairo_line_to (cr, endx, endy); cairo_stroke (cr); }
Created attachment 298703 [details] rendering of start-arrow after applying patch
Sure, it's nicer. What's your name so that we can credit you for the fix and ChangeLog and NEWS?
My name is Johannes Deutsch. best regards
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution. Patch applied. Thanks.