After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745693 - Classic mode: Default user avatar is almost invisible on lock screen
Classic mode: Default user avatar is almost invisible on lock screen
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-05 17:32 UTC by Vadim Rutkovsky
Modified: 2015-03-12 15:17 UTC
See Also:
GNOME target: 3.16
GNOME version: ---


Attachments
Screenshot (258.14 KB, image/png)
2015-03-05 17:32 UTC, Vadim Rutkovsky
  Details
theme: Fix default avatar color on screen shield (856 bytes, patch)
2015-03-11 16:53 UTC, Florian Müllner
none Details | Review

Description Vadim Rutkovsky 2015-03-05 17:32:34 UTC
Created attachment 298653 [details]
Screenshot

STR:
1. Make sure the user has default avatar and password set
2. Lock the screen
3. Press any key

Result: default avatar is not displayed

If user has avatar set it will be displayed correctly. Gnome/gnome-wayland session display the avatar correctly

continuous 20150305.62
gnome-shell 3.15.91-4-g94c3c8f412ce997f1ff5fadb6f9a78f7ba5891c3
gnome-shell-extensions 3.15.91-0-g44cbe64e30b1500b7c52b1295b9fb98facdf946e
Comment 1 Ray Strode [halfline] 2015-03-09 17:33:46 UTC
can you attach journal output?
Comment 2 Florian Müllner 2015-03-09 17:37:17 UTC
(In reply to Ray Strode [halfline] from comment #1)
> can you attach journal output?

It's a theme issue - if you look really closely, the avatar image is there, but uses a dark color that is almost indistinguishable from the background ...
Comment 3 Ray Strode [halfline] 2015-03-09 20:22:25 UTC
you have a very keen eye. I can't see that, with my face inches from the screen.
Comment 4 Florian Müllner 2015-03-09 20:24:55 UTC
Heh - it's not like it sprang to my eye either, but I took a closer look because it seemed like the most likely option, considering that the normal/wayland sessions work fine according to comment #0 :-)
Comment 5 Vadim Rutkovsky 2015-03-09 20:40:47 UTC
(In reply to Florian Müllner from comment #4)
> Heh - it's not like it sprang to my eye either, but I took a closer look
> because it seemed like the most likely option, considering that the
> normal/wayland sessions work fine according to comment #0 :-)

Indeed, it works correctly for other sessions and there is a greyed out avatar displayed (zooming at 400% helped)
Comment 6 Jakub Steiner 2015-03-10 11:45:43 UTC
I can't seem to find an appropriate selector for this though.

I would have thought it's

.framed-user-icon { color: pink; }

or

.framed-user-icon StIcon { color: pink; }

but it doesn't appear so.
Comment 7 Florian Müllner 2015-03-11 16:53:42 UTC
Created attachment 299116 [details] [review]
theme: Fix default avatar color on screen shield

Unlike the default text color, the border color works in both
normal and classic session ...


(In reply to Jakub Steiner from comment #6)

> I would have thought it's
> 
> .framed-user-icon { color: pink; }
> 
> or
> 
> .framed-user-icon StIcon { color: pink; }

Yes, either of those should work - the attached patch does the job for me in testing, ok to push?
Comment 8 Jakub Steiner 2015-03-12 15:01:53 UTC
Ah, I got hit by the git submodule confusion for this one as well. I'll push a version with using the $osd_fg_color as that's what the common color between light/dark is (gnome vs classic).