After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745648 - Song view elements jump around
Song view elements jump around
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: 3.16
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-05 00:40 UTC by Carlos Garnacho
Modified: 2015-03-05 10:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screencast of the problem (945.49 KB, application/octet-stream)
2015-03-05 00:40 UTC, Carlos Garnacho 		  Details
view: Fix inconsistent allocations of cell renderers (3.27 KB, patch)
2015-03-05 00:41 UTC, Carlos Garnacho 		none Details | Review

Description Carlos Garnacho 2015-03-05 00:40:37 UTC 
Created attachment 298590 [details]
Screencast of the problem

Each time gnome-music restarts, the "Songs" view elements jump around briefly when vs after loading.

I wouldn't think it's such a good idea to stuff everything on a single treeview column, it will be friendlier to the treeview to distribute the cell renderers across several columns, so the size can be properly negotiated for these.

I'm attaching a patch doing that, it fixes the jumpiness seen in the video.
Comment 1 Carlos Garnacho 2015-03-05 00:41:15 UTC 
Created attachment 298591 [details] [review]
view: Fix inconsistent allocations of cell renderers

GtkTreeView doesn't handle as nicely size allocation between cells in
a column than between columns themselves. Distributing these in several
columns makes it easier to ensure the size stays consistent across tree
validation, which results in no jumping rows afterwards.
Comment 2 Vadim Rutkovsky 2015-03-05 10:35:55 UTC 
Excellent, pushed as https://git.gnome.org/browse/gnome-music/commit/?id=3924cac