After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745626 - appFavorites: Add gnome-terminal to the rename list
appFavorites: Add gnome-terminal to the rename list
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 711059
Blocks:
 
 
Reported: 2015-03-04 17:32 UTC by Bastien Nocera
Modified: 2017-02-16 00:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
appFavorites: Add gnome-terminal to the rename list (901 bytes, patch)
2015-03-04 17:33 UTC, Bastien Nocera 		committed Details | Review
appFavorites: Only use renamed ID if it can be resolved (1.43 KB, patch)
2015-03-04 18:26 UTC, Florian Müllner 		committed Details | Review

Description Bastien Nocera 2015-03-04 17:32:57 UTC 
.
Comment 1 Bastien Nocera 2015-03-04 17:33:02 UTC 
Created attachment 298560 [details] [review]
appFavorites: Add gnome-terminal to the rename list
Comment 2 Florian Müllner 2015-03-04 17:49:07 UTC 
Review of attachment 298560 [details] [review]:

Yes, once gnome-terminal actually renames its .desktop file - at least for now, the mapping is non-optional in the code, so if a new name exists, it will be used instead of the old one, even when only the old name can be resolved to an app.
Comment 3 Florian Müllner 2015-03-04 18:26:09 UTC 
Created attachment 298563 [details] [review]
appFavorites: Only use renamed ID if it can be resolved

This would allow us to carry the patch upstream even before gnome-terminal actually renames its .desktop file ...
Comment 4 Florian Müllner 2015-11-14 18:55:42 UTC 
Comment on attachment 298560 [details] [review]
appFavorites: Add gnome-terminal to the rename list

Attachment 298560 [details] pushed as 78db025 - appFavorites: Add gnome-terminal to the rename list
Comment 5 Debarshi Ray 2016-03-29 14:07:47 UTC 
Now that gnome-terminal has actually renamed its .desktop file upstream, can this bug be closed?
Comment 6 Florian Müllner 2016-03-29 14:44:35 UTC 
Yup.
Comment 7 Florian Müllner 2017-02-16 00:39:00 UTC 
Comment on attachment 298563 [details] [review]
appFavorites: Only use renamed ID if it can be resolved

Attachment 298563 [details] pushed as 2c5bc4a - appFavorites: Only use renamed ID if it can be resolved