GNOME Bugzilla – Bug 745611
video-sink: advertize the GstVideoOverlayComposition feature in caps
Last modified: 2015-05-09 14:07:14 UTC
The following patch let the video-sink advertize for the GstVideoOverlayComposition feature in the caps it returns and not only the static caps. GST_DEBUG=pango:6 gst-launch-1.0 videotestsrc ! textoverlay text="foo" ! clutterautovideosink 2>&1 |grep 'Downstream accepts the overlay meta' should now returns, something like: 0:00:00.094042545 14049 0x2f62400 DEBUG pango gstbasetextoverlay.c:761:gst_base_text_overlay_negotiate:<textoverlay0> Downstream accepts the overlay meta: 1
Created attachment 298546 [details] [review] video-sink: advertize the GstVideoOverlayComposition feature in caps
Created attachment 298555 [details] [review] video-sink: advertize the GstVideoOverlayComposition feature in caps Patch updated: - the static caps now advertize missing video/x-raw(meta:GstVideoGLTextureUploadMeta, meta:GstVideoOverlayComposition),format=BGRA - append_cap now adds properly the GstVideoOverlayComposition feature to the non-fixed renderer caps.
Ping.
I thought from our discussion on IRC, you had to update this patch. Am I wrong?
I think the second version of the patch is fine and correct the issues we've discussed over IRC (Unless i've missed something, the patch works with the various color formats that the video-sink supports).
Created attachment 301189 [details] [review] video-sink: advertize the GstVideoOverlayComposition feature in caps Patch rebased on top of current master.
Pushed to master/3.0, thanks and sorry for the delay.