After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745608 - Support the C99 'bool' type
Support the C99 'bool' type
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: g-ir-scanner
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-03-04 15:07 UTC by Emmanuele Bassi (:ebassi)
Modified: 2015-03-04 15:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
scanner: Support the C99 'bool' type (1.26 KB, patch)
2015-03-04 15:07 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2015-03-04 15:07:42 UTC 
Took me a little bit to figure this out, with the scanner failing in the arguments of the function, instead of failing with the return
type. Anyway, since we support `_Bool`, `true`, and `false`, as well as the C99 stdint sized integer types, we may as well support the
C99 stdbool `bool` type. This makes a bunch of Graphene API suddenly appear in the GIR.
Comment 1 Emmanuele Bassi (:ebassi) 2015-03-04 15:07:46 UTC 
Created attachment 298541 [details] [review]
scanner: Support the C99 'bool' type

Otherwise API using it will badly break in weird ways.
Comment 2 Colin Walters 2015-03-04 15:15:52 UTC 
Review of attachment 298541 [details] [review]:

Could use a test case, although that might involve some build-time conditionals to detect C99 or something.

But looks reasonable to me.
Comment 3 Emmanuele Bassi (:ebassi) 2015-03-04 15:39:01 UTC 
Attachment 298541 [details] pushed as 62c634a - scanner: Support the C99 'bool' type