After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745536 - Regression between gtk+ 2.24.25 and gtk+ 2.24.26 with spotify linux client
Regression between gtk+ 2.24.25 and gtk+ 2.24.26 with spotify linux client
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-03-03 15:25 UTC by Christophe Fergeau
Modified: 2015-03-03 16:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Backport of 806c04411 to the 2.24 branch (7.89 KB, patch)
2015-03-03 15:25 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2015-03-03 15:25:58 UTC 
Created attachment 298442 [details] [review]
Backport of 806c04411 to the 2.24 branch

After upgrading to gtk+ 2.24.26, the spotify linux client (closed source) started crashing fairly regularly (for example when playing Crystal Castles/Fainting Spells).
Reverting https://git.gnome.org/browse/gtk+/commit/?id=ee95f3d7259c0859ce41189b781b4339b4cd64aa "Make gdk_event_apply_filters safe against changes in filter list" avoids the crash.

Looking in gtk3 history, the backported commit had a followup:
https://git.gnome.org/browse/gtk+/commit/?id=806c04411d306680353cf90cffee98ce73e122f2
"gdk: Fix GdkWindowFilter internal refcounting"

Backporting this patch on top of gtk+ 2.24.26 avoids the crash too.
Comment 1 Matthias Clasen 2015-03-03 15:34:12 UTC 
Review of attachment 298442 [details] [review]:

Thanks for the detective work, Christophe!
Comment 2 Christophe Fergeau 2015-03-03 16:27:32 UTC 
Pushed as commit 5efefdb6550b3f00d5ca159c2ff74326bfd0e94b and commit 22eb70adab72a5c14f063ea15f8195087ff1dcd8
I realized I had inadvertantly squashed 2 commits, so I split them again to stay as close as possible to the gtk3 branch.