Created attachment 298358 [details] [review]
dateMenu: Hide displays section when disabled by session mode

We currently show the world clocks section unconditionally, even when
the session mode disallows launching the Clocks app to configure the
displayed clocks. This does not make sense, so hide the entire section
when the session mode disallows settings.

Created attachment 298359 [details] [review]
calendar: Respect session mode for section visibility

It doesn't make much sense to show a section if it must remain empty
due to the session mode - there won't be any events if the session
mode disallows events, or notifications if those are disallowed. So
take the session mode into account and update the sections' visibility
accordingly.

Created attachment 298360 [details] [review]
calendar: Hide message list when all sections are disallowed

If none of the sections is allowed to display anything, it doesn't
make sense to show the message list at all, so hide it in that case.

Created attachment 298362 [details] [review]
dateMenu: Move bottom-padding into displays-section

We don't need additional padding when the column contains only the
calendar.

Created attachment 298364 [details] [review]
calendar: Respect session mode for section visibility

Fix session mode property for events, whoops.

Review of attachment 298362 [details] [review]:

sure

Review of attachment 298358 [details] [review]:

ok

Review of attachment 298360 [details] [review]:

right

Review of attachment 298364 [details] [review]:

Looks good

::: js/ui/calendar.js
@@ +1254,3 @@
+        let id = Main.sessionMode.connect('updated',
+                                          Lang.bind(this, this._sync));
+        this.actor.connect('destroy', function() {

Obviously correct but I couldn't find any place where MessageListSections are destroyed.

(In reply to Rui Matos from comment #9)
> Obviously correct but I couldn't find any place where MessageListSections
> are destroyed.

Right, we don't destroy our built-in sections. Still, extensions might want to add their own sections, which need to be removed/destroyed on disable() ...

Attachment 298358 [details] pushed as 61c5f25 - dateMenu: Hide displays section when disabled by session mode
Attachment 298360 [details] pushed as db4076b - calendar: Hide message list when all sections are disallowed
Attachment 298364 [details] pushed as 313ee70 - calendar: Respect session mode for section visibility

Created attachment 298490 [details]
Calendar with and without extra padding

So I got myself a fixed mesa build and can take screenshots again - here's a comparison between master (extra padding at bottom) and with the remaining patch applied.
Jakub?

my vote goes to the right: strip the padding

strip the padding indeed