After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745487 - Missing colors caused by some evolution calendar sources
Missing colors caused by some evolution calendar sources
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: User Interface
3.15.x
Other Linux
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-03 00:54 UTC by Sebastian Keller
Modified: 2017-04-17 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
app: Fix missing colors caused by some evolution calendar sources (1.48 KB, patch)
2015-03-03 00:54 UTC, Sebastian Keller 		none Details | Review

Description Sebastian Keller 2015-03-03 00:54:34 UTC 
Created attachment 298357 [details] [review]
app: Fix missing colors caused by some evolution calendar sources

I have some evolution calendar sources with colors that are represented as long hexadecimal string, such as "#fcfcafaf3e3e". These are used to generate CSS from but are not valid CSS colors, which results in errors such as this:

** (gnome-calendar:27761): WARNING **: Error creating custom stylesheet. <data>:5:40Junk at end of value

I'm attaching a patch that fixes this. Feel free to push it if you think it is correct since I've not applied for a git account yet.
Comment 1 Erick Perez Castellanos 2015-03-04 18:19:15 UTC 
I'm not sure about the patch. I'll sit on it a few days to see if I can come up with some parsing of some kind.
Comment 2 Erick Perez Castellanos 2015-03-06 16:40:37 UTC 
Just made a fix. Pushed as c7563da. I'm still not happy with it. We should handle calendars colors better. I'll leave the bug open because of it.
Comment 3 Erick Perez Castellanos 2015-03-16 17:29:43 UTC 
Comment on attachment 298357 [details] [review]
app: Fix missing colors caused by some evolution calendar sources

Code has been submitted to fix this partially.
Comment 4 Georges Basile Stavracas Neto 2016-07-08 04:34:49 UTC 
This bug does not seem to affect the color parsing code anymore. Thanks for the fix, Erick.