After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745480 - Strange gettext construction
Strange gettext construction
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other All
: Normal minor
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-03-02 21:23 UTC by Marek Černocký
Modified: 2015-03-04 08:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix erroneous ngettext use (1.42 KB, patch)
2015-03-03 20:49 UTC, Matthias Clasen 		committed Details | Review

Description Marek Černocký 2015-03-02 21:23:28 UTC 
In src/backend/bacon-video-widget-gst-missing-plugins.c:

message_text = g_strdup_printf (ngettext (N_("%s is required to play the file, but is not installed."),
                                          N_("%s are required to play the file, but are not installed."),
                                          g_strv_length (ctx->descriptions)),
                                descriptions_text);

Why is used macro N_ inside ngettext? It may cause problems for languages with more plural forms.
Comment 1 Matthias Clasen 2015-03-03 20:49:19 UTC 
Created attachment 298482 [details] [review]
Fix erroneous ngettext use

No need to wrap strings in ngettext calls in N_().