After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745463 - Search suggestions are not shown in Clocks / Weather
Search suggestions are not shown in Clocks / Weather
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: Vadim Rutkovsky
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-03-02 14:59 UTC by Vadim Rutkovsky
Modified: 2015-03-10 10:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot (267.79 KB, image/png)
2015-03-09 12:13 UTC, Vadim Rutkovsky 		  Details
entrycompletion: Ensure transient_for is set before showing window (2.40 KB, patch)
2015-03-09 14:24 UTC, Carlos Garnacho 		accepted-commit_now Details | Review

Description Vadim Rutkovsky 2015-03-02 14:59:21 UTC 
Typing a part of the city doesn't show search suggestions for cities in Weather/Clocks running in a wayland session with GDK_BACKEND=wayland

Might be a duplicate of bug 735826
Comment 1 Matthias Clasen 2015-03-02 18:18:22 UTC 
is this simply a matter of the popover popping up towards the top ?
Comment 2 Vadim Rutkovsky 2015-03-03 17:46:35 UTC 
(In reply to Matthias Clasen from comment #1)
> is this simply a matter of the popover popping up towards the top ?

No, the suggestion box is not displayed at all
Comment 3 Matthias Clasen 2015-03-07 19:59:40 UTC 
is this still happening ?
Comment 4 Vadim Rutkovsky 2015-03-09 12:13:28 UTC 
Created attachment 298872 [details]
Screenshot

Still occurs with both GDK_BACKEND set and unset.

gtk3 3.15.10-46-g01d76b7701f6b8d3e5654d679fb291826cf970bf
Comment 5 Carlos Garnacho 2015-03-09 14:24:40 UTC 
Created attachment 298883 [details] [review]
entrycompletion: Ensure transient_for is set before showing window

gtk_entry_set_completion() (and _gtk_entry_completion_connect underneath)
may happen when the entry has no toplevel yet. This window acts as the
"parent" for subsurface windows on wayland, and is indispensable to create
its backing wl_subsurface, so this resulted in non-visible popups there.
Fix this by ensuring transient_for is set before showing the popup.
Comment 6 Matthias Clasen 2015-03-10 00:11:13 UTC 
Review of attachment 298883 [details] [review]:

looks good to me
Comment 7 Carlos Garnacho 2015-03-10 10:17:00 UTC 
Attachment 298883 [details] pushed as 94ec6b4 - entrycompletion: Ensure transient_for is set before showing window